Repository navigation
Confirm pauses on GitHub and alert people when they are not - #218
Conversation
The design's procedure P counts a pause only once it is observed: the service must see the PR out of the queue and a draft. A pause not confirmed within 5 minutes goes to people with the commands to do it by hand. Until now an ack alone marked a PR paused, and a pause that never ran went unnoticed. - pause_open_prs records each pause request's time and reason. - A "paused" change set (acked) is confirmed only when GitHub shows the PR as a draft (a draft cannot be in, or re-enter, the merge queue). Otherwise the pause is issued again, and a confirmed PR observed un-drafted later counts as unconfirmed again (with a fresh alert clock). Pause tracking runs before head checks, so a paused PR whose head moves stays watched. A completed re-pause (its ack, or a confirmation) clears the pending item, so a later undo is re-paused at once instead of waiting out the old item. - A request neither acked nor confirmed 5 minutes later goes to people once, with "remove it from the merge queue" and `gh pr ready <n> --undo`. The escalation does not depend on GitHub answering: if reading a PR fails, only that change set is skipped, and an overdue pause still goes to people. - kb status reports pause_unconfirmed per repository: a breaker or rollback is not complete while it is non-zero. kb resume clears the bookkeeping, also for requests that were never acked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7721ef538e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requested = float(detail.get("pause_requested_at") or 0) | ||
| if not requested or detail.get("pause_alerted") or detail.get("pause_confirmed") \ | ||
| or rt.clock() - requested < PAUSE_CONFIRM: |
There was a problem hiding this comment.
When this version starts with a change set already in paused status from the previous release, its detail has no pause_requested_at. If GitHub does not show the PR as a draft, advance() reissues the pause, but neither that retry nor this helper initializes the timestamp; this early return therefore repeats forever. Such a PR is reported by pause_unconfirmed() but never escalated to people after five minutes, defeating the new safety behavior during an upgrade. Initialize tracking when an untracked paused row is encountered, or derive a deadline from the retry/row timestamp.
Useful? React with 👍 / 👎.
Knowledge-service redesign follow-up, from the design's procedure P: a pause counts only once it is observed on GitHub, and a pause not confirmed within 5 minutes goes to people. Before this, an ack alone marked a PR paused.
kb statusreportspause_unconfirmedper repository (a breaker or rollback isn't done until it reaches 0), andkb resumeclears the bookkeeping, including never-acked requests.Commit hook approved; full suite and SPEC freshness pass locally (rebased on #217).
🤖 Generated with Claude Code