Repository navigation
Keep knowledge snapshots that unfinished runs pinned - #223
Conversation
Strict and quality runs pin the knowledge snapshot active at reservation (#213), and the design requires that a snapshot referenced by any unfinished run is never deleted. Pruning kept only the newest ten plus the active one, so a long queue could lose a pinned snapshot and fail those runs. - activate.prune also keeps every snapshot that a run pinned (<run>/knowledge.json) while that run is not terminal, or is an interrupted reservation that never launched (it can be reclaimed and will run with its original pin). - Switching the active snapshot records when the previous one stopped being active, and pruning never removes a snapshot deactivated less than an hour ago. A reservation that resolved it just before the switch publishes its pin within that window. The review runs live in other processes (and possibly other hosts) that cannot share the service's activation lock, so the coordination is this grace period. - The run directories come from KB_RUN_ROOTS (os.pathsep-separated, for several servers), else the runs' EFFECTIVE run_root (environment or the .env files Settings reads). - An autouse test fixture points KB_RUN_ROOTS at an empty directory, so tests never read the real ~/.infermatrix-copilot/runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bdef4e112
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| marker = root / DEACTIVATED.format(name=old.name) | ||
| if marker.exists() and now - marker.stat().st_mtime < PIN_GRACE: | ||
| continue # deactivated too recently: a reservation may be pinning it right now |
There was a problem hiding this comment.
When a reservation process resolves the old active snapshot and is then stalled for more than PIN_GRACE before writing knowledge.json, a later activation can find that snapshot outside the newest ten and delete it here because its marker has expired and its pin is not yet visible. When the reservation resumes, it writes a dangling pin and _launch fails the queued review as unavailable, violating the stated invariant that an unfinished run's snapshot is never deleted. Pin publication needs synchronization or durable in-progress reservation tracking rather than a finite timeout alone.
Useful? React with 👍 / 👎.
Knowledge-service redesign follow-up (§8.5): a snapshot referenced by an unfinished run is never deleted. Strict/quality runs pin their snapshot at reservation (#213), but pruning only kept the newest ten plus the active one.
activate.prunekeeps every snapshot pinned (<run>/knowledge.json) by a non-terminal run, or by an interrupted reservation that never launched (it can be reclaimed). Each run status is read once, so a concurrent reclaim can't slip between reads.KB_RUN_ROOTS, else the runs' effectiverun_root(environment or.env).Commit hook approved; full suite and SPEC freshness pass locally.
🤖 Generated with Claude Code