Skip to content

Document the single-maintainer setup for the knowledge gate - #226

Merged
tzhouam merged 1 commit into
mainfrom
kb/single-maintainer
Sep 29, 2026
Merged

tzhouam merged 1 commit into
mainfrom
kb/single-maintainer

Conversation

@tzhouam

@tzhouam tzhouam commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

The owner decided not to add a second knowledge maintainer, so CODEOWNERS and the cutover steps are updated to match.

  • The human-approved path covers PRs opened by others.
  • The ruleset is split in two so the owner's code-owner bypass never bypasses kb-gate:
    • main-gate, no bypass: merge queue, kb-gate required from GitHub Actions, no deletion or force push;
    • main-code-owners, owner is the only bypass: pull request, code-owner review, dismiss stale approvals.

Docs and comments only. The commit hook approved it.

🤖 Generated with Claude Code

The owner decided that no second knowledge maintainer will be added. The
CODEOWNERS comment and the feature doc's cutover steps now say so.

- The human-approved path covers PRs opened by others; the service's own PRs
  that go to people are closed or amended and re-gated.
- The rules are split in two, so the owner's code-owner bypass never
  bypasses kb-gate:
  - main-gate, with no bypass: merge queue, kb-gate required from GitHub
    Actions, no deletion or force push;
  - main-code-owners, with the owner as the only bypass: pull request,
    code-owner review, dismiss stale approvals.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T02:51:49.099406Z 0282809 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 028280953e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CODEOWNERS
Comment on lines +13 to +14
# own changes here go through the owner's bypass of the code-owner ruleset
# (see doc/features/knowledge-service.md), never through kb-gate's.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the obsolete approval guarantee

When @tzhouam authors a change under .github/**, this newly documented bypass allows it to merge without a Code Owner approval, directly contradicting lines 3–5, which still claim that no such change can land without a maintainer approving the current head. Because this comment describes the gate's security guarantees, update that earlier statement to acknowledge the single-maintainer bypass.

Useful? React with 👍 / 👎.

@tzhouam
tzhouam merged commit 9815429 into main Sep 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant