Repository navigation
kb init: modules stage (module map cards and routes) - #251
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eebcef89bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+316
to
+320
| if used + size > MAX_CARD_BYTES: | ||
| entry = {"path": rel} | ||
| size = len(rel) + 12 | ||
| listed.append(entry) | ||
| used += size |
There was a problem hiding this comment.
When a module's detailed entries reach MAX_CARD_BYTES, each remaining file is still appended as a path-only entry, and used can continue growing without limit until the separate 200-file cap. A module with many long paths can therefore produce a prompt substantially larger than the advertised 40 KB bound, potentially exceeding the model context or increasing cost and blocking the entire stage. Stop adding entries when even the path-only form would exceed the remaining byte budget.
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tzhouam
force-pushed
the
kb/init-modules
branch
from
September 30, 2026 12:27
eebcef8 to
946a406
Compare
tzhouam
added a commit
that referenced
this pull request
Sep 30, 2026
modules (#251), deepen (#252) and harvest-calibration (#254) landed, so the skill no longer treats them as unimplemented: it runs the next stage and says what each one opens. The rules are unchanged: only MERGED PRs count as done when publishing, and dry-run records chain in dry-run mode. It notes that harvest refuses fewer than five owner-or-synthetic bad cases, and that auto_merge still needs kb calibrate and the shadow period (the skill never flips it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stage 1 of kb init (design kb-init v3): bootstrap a repository's knowledge base from its docs and seed pages, as one human-merged PR. - init_budget: hard per-stage ceiling by reservation. A generator call reserves threshold + one worst-case request (claude's --max-budget-usd only stops the next request); models without a price are refused before any call. Judge calls are accounted at a fixed cost. - init_support: InitRuntime (never KbRuntime, so never kb.db), the per-stage InitRecord, the upstream pin (bare mirror; the pin defaults to the mirror's HEAD, i.e. the upstream default branch, never an assumed main; safe export; PinnedObserver), model calls through the budget, claim/evidence and outside-knowledge path checks, the CI knowledge validators on the result, and InitPublisher (one deterministic commit on an exact base, pushed to a branch that must not exist, PR via the owner's gh; or a local dry run). Writes need ALLOW_PUSH=1, ALLOW_POST=1 and KB_INIT_GIT_AUTHOR (checked before any model call); private upstreams are always dry runs. INIT_PATHS allows knowledge/repos/_index.md, the shared list a new repository joins. - init_stages: run_stage + validate_change (the only check_changeset(bootstrap=True) caller). Skeleton: map call (entry page, architecture page, routes, general links), doc-invariant rules, adapted seed pages. Every rule is D5-filtered, evidenced and checked at the pin, then PLACED on a running tree before judging (a page that fills up sends the rule to a sibling page), so the advisory judge sees each rule where it is written; fail verdicts are stripped. Existing pages are only appended to; routes start from owners read deterministically from existing sub-directory entry pages (code paths they name that exist at the pin); findings on existing pages go to the PR checklist; a failed push is recorded as blocked. suggest_seeds ranks candidates without a model call. - InitConfig gains generator_call_usd and harness_overhead_bytes; build_doc_corpus takes optional globs (doc_files). - knowledge.init step, kb-init playbook, `kb init REPO --stage S [--dry-run] [--pin SHA]` and `kb init REPO --suggest-seeds`, dispatched before any ledger is opened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
L1 reads any line starting with "## <Word>" as a rule ID (lifecycle.RULE_HEADING / ANY_RULE_HEADING), so a model-written "## Overview" or "## SERV-1 — x" in architecture.md or the entry page intro could collide with real rule IDs or masquerade as a rule. Every non-rule page the skeleton writes now goes through neutral_headings: an ATX heading outside code becomes a bold paragraph, any other line that starts with "#" is escaped, and such a line inside a fence is indented by one space. No line starts with "#", so the rule regexes (all anchored at column 0) can never match. The entry page's list heading is bold too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tzhouam
force-pushed
the
kb/init-skeleton
branch
from
September 30, 2026 15:36
b10547b to
7e98f94
Compare
Stage 2 of kb init (design v3 §7.1-7.2): route every code module. - init_stages: the skeleton's flow becomes a _Stage base shared by every stage (pin, record, rule screening and placement, the deterministic checks as _conclude, the publication); _Skeleton keeps only its own steps. New: the stage chain. Each earlier stage must be merged (record published and gh pr view MERGED, so main holds it), or, for a dry run of this stage, dry-run: its snapshot is overlaid on main as the base and handed to the knowledge validators with this stage's change. A stage with nothing to change is recorded "empty", not blocked. Later stages keep the earlier stages' pin unless --pin says otherwise. - init_modules: scan_modules_at_depth at the pin (language from the adapter's repo.language; none or unknown -> no scan, checklist). A module an owner partly reaches is absorbed: its prefix is appended to that owner's scope_prefixes. Every other module gets one bounded generator call (file names, signatures, leading docstrings, never bodies) and a map card: a prose page (type architecture) in an existing components/<group>/ (index append-only) or a new group with its own _index.md and route owner, linked upward. Sections are bold labels: the knowledge format reads any "## <Word>" heading as a rule ID. The route table is only appended to (routes_append_only). Budget or card cap -> the cards written so far still make a PR; the rest is listed. - InitRecord.coverage: the stage's coverage report, rendered as a before/after table in the PR body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tzhouam
force-pushed
the
kb/init-modules
branch
from
September 30, 2026 15:37
946a406 to
f24e5d1
Compare
tzhouam
added a commit
that referenced
this pull request
Sep 30, 2026
modules (#251), deepen (#252) and harvest-calibration (#254) landed, so the skill no longer treats them as unimplemented: it runs the next stage and says what each one opens. The rules are unchanged: only MERGED PRs count as done when publishing, and dry-run records chain in dry-run mode. It notes that harvest refuses fewer than five owner-or-synthetic bad cases, and that auto_merge still needs kb calibrate and the shadow period (the skill never flips it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 2 of
kb init(design v3 §7.1–§7.2): every code module gets a route.init_stages._Skeletonis split into a_Stagebase, which every stage uses, plus_Skeleton. The base handles the pin, the record, rule screening and placement, the deterministic checks (_conclude) and publishing. It's behaviour-preserving: all skeleton tests pass unchanged except one, which now expectsdeepenrather thanmodulesto be unimplemented.publishedandgh pr viewsaysMERGED, so main already holds it.empty, which doesn't block the next stage.--pinsays otherwise. The chain state is part of the inputs digest.init_modules.scan_modules_at_depthat the pin. The language comes from the adapter'srepo.language; if none is declared or it's unknown, nothing is scanned and a checklist item is added.scope_prefixes.type: architecture) listing purpose, entry points, key files (only files that exist in the module), docs to read (only files in the doc set) and routes.components/<group>/(append-only index, append-only owner), or into a new group with its own_index.mdand route owner, linked from the page above it._routes.yamlis only appended to;routes_append_onlyguards this.InitRecord.coverage: the stage's coverage report, rendered as a before/after table in the PR body.Deviations and findings
##headings. The knowledge format reads any## <Word> …heading as a rule ID, so English card headings collided (duplicate_rule_id). The skeleton stage'sarchitecture.mdhas the same hazard when the model writes English##headings. PR kb init: skeleton stage (docs map, doc invariants, seeds) with its own runtime, budget and publisher #248 should strip or convert those; I noted it for the owner and did not fix it here.declaration()cuts each signature at the earliest{/=>/;/ lone=, without lexing strings, comments or regex literals. A body can't start earlier, so nothing after it is sent; a default value may be cut short. Python uses a bracket-, string- and comment-aware scan up to the header's:. The commit gate found three JS lexing holes in a scanner version first, which is why the simpler rule won.Tests
test/test_kb_init_modules.py(11 tests):emptystageroutes_append_only,declaration,_leading_doc, an emptyowners:tableimc-check.sh: rc=0 (full pytest, doc links and citations, SPEC freshness--strict, knowledge linters).Part 6/9 of kb init (design v3, sol-approved), stacked on #248.
🤖 Generated with Claude Code