Skip to content

knowledge(vllm-omni): 1 change(s) from refine - #355

Merged
tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-refine-608b8dcc5bcb
Oct 12, 2026
Merged

tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-refine-608b8dcc5bcb

Conversation

@tzhouam

@tzhouam tzhouam commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Generated automatically by the Copilot knowledge service (changeset vllm-omni-refine-608b8dcc5bcb).

op page rule
add repos/vllm-omni/models/seedvr2/rules.md VLLM-OMNI-PR8767-SEEDVR2-RMSNORM-FP32

Generator: zcode:GLM-5.3 · judge: codex:gpt-6-sol:medium.
The publisher merges it only if its local gate passes on the exact merge result.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T15:10:11.000001Z fa53f56 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tzhouam
tzhouam merged commit d94304c into main Oct 12, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa53f5606f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

公开 route 与 artifact readiness 见 [Serving 请求规则](../../components/serving/rules.md);
分布式执行与 VAE ownership 见 [Diffusion 规则](../../components/diffusion/rules.md)。

## VLLM-OMNI-PR8767-SEEDVR2-RMSNORM-FP32 — SeedVR2 RMSNorm 的低精度统计必须在 FP32 中累计

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route the new RMSNorm rule from the owner entrypoints

Add this nadit.py/RMSNorm trigger to both the page's Direct 代码快速入口 table and models/seedvr2/_index.md. As committed, those entrypoints only advertise clip-budget and long-video concerns, so a review starting from the bounded Direct quick map or owner index can miss the new active rule entirely, defeating its purpose for future numerical changes.

AGENTS.md reference: AGENTS.md:L23-L24

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant