Repository navigation
knowledge(vllm-omni): 1 change(s) from refine - #355
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa53f5606f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 公开 route 与 artifact readiness 见 [Serving 请求规则](../../components/serving/rules.md); | ||
| 分布式执行与 VAE ownership 见 [Diffusion 规则](../../components/diffusion/rules.md)。 | ||
|
|
||
| ## VLLM-OMNI-PR8767-SEEDVR2-RMSNORM-FP32 — SeedVR2 RMSNorm 的低精度统计必须在 FP32 中累计 |
There was a problem hiding this comment.
Route the new RMSNorm rule from the owner entrypoints
Add this nadit.py/RMSNorm trigger to both the page's Direct 代码快速入口 table and models/seedvr2/_index.md. As committed, those entrypoints only advertise clip-budget and long-video concerns, so a review starting from the bounded Direct quick map or owner index can miss the new active rule entirely, defeating its purpose for future numerical changes.
AGENTS.md reference: AGENTS.md:L23-L24
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-608b8dcc5bcb).repos/vllm-omni/models/seedvr2/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.