Repository navigation
knowledge(vllm-omni): 2 change(s) from refine - #368
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a850672d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sample 数与 history duration 一致；覆盖 0/中间/末尾 truncate、缺 token/duration 与 | ||
| tool responses；已有合法 content_index/audio length 检查先于 history 修改。^[PR #8339] | ||
|
|
||
| ## VLLM-OMNI-PR8840-RT-CANCEL-CODE — 迟到/无目标的 response.cancel 必须返回 OpenAI 标准 response_cancel_not_active |
There was a problem hiding this comment.
When a Direct review is triggered by response.cancel, the page's quick map still routes that signal only to SERV-RT-1c, which does not contain this new error-code invariant. Because reviewers are expected to stop navigation after using the embedded quick map, they can miss the response_cancel_not_active requirement entirely; add this rule ID and _handle_response_cancel source entry to the existing map row and synchronize the nearest _index.md.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
| - 禁止：finished row 无条件跳过而连续输出零 token；在重新交付时再次运行 synthesis；把未确认的部分 recompute 当作完整 accepted history；finish/abort 后遗留 job 或 timing state。 | ||
| - 验收：确定性回归让 scheduler 丢弃交付 step，恢复后仍得到同一音频/end token且只完成一次 synthesis；再覆盖真实 eager/graph preemption、取消与后续请求恢复。^[PR #8407] | ||
|
|
||
| ## VLLM-OMNI-PR8851-YUE2-SAMPLER-COST — 削减全词表一致性循环不得丢失边界覆盖 |
There was a problem hiding this comment.
For a PR mentioning test_yue2_sampler.py, sampling-loop steps, or min_tokens, none of the four existing quick-map rows returns this newly added rule, so the Direct workflow can stop on unrelated synthesis/interface groups without applying these coverage constraints. Add a sampler/test-cost row pointing to this rule and its test file, and update the YuE2 _index.md so the owner route exposes the new concern.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-refine-ed5d7bcfdb72).repos/vllm-omni/components/serving/rules-realtime-openai.mdrepos/vllm-omni/models/yue2/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.