Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #389
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45f6ae7dab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # vllm-omni AMD/ROCm CI 流水线规则 | ||
|
|
||
| ## VLLM-OMNI-PR9227-R2-01-SHARDING — AMD READY R2-01 双分片：pytest-shard 切分、分片独占工件、fail-closed 与超时保留 |
There was a problem hiding this comment.
When a review touches .buildkite/amd/**, knowledge/repos/vllm-omni/_index.md:27 routes it directly to ci/rules.md, whose AMD entry at lines 35–36 points to ci/rules-amd.md; owner-scoped navigation therefore never loads this new repository-root page. Merge this rule into the existing AMD CI rule page and update the CI index/routing there instead of creating a parallel root-level owner.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
| ## VLLM-OMNI-PR9227-R2-01-SHARDING — AMD READY R2-01 双分片：pytest-shard 切分、分片独占工件、fail-closed 与超时保留 | ||
|
|
||
| - 触发：改动 `.buildkite/amd/test-amd-ready.yml`（AMD READY 通道，区别于 PR #8014 覆盖的 MERGE 通道 test-amd-merge.yml）中 `ROCm · Model Executor GPU Coverage (R2-01) · Shard %N/%t` 步骤——`parallelism`、pytest 命令、junit/log/summary 工件路径、超时或 grade——或 `tests/buildkite/test_amd_ready_r2_01.py` 结构回归测试的断言。 | ||
| - 强制：R2-01 必须保持 `parallelism: 2` 的两个并行 `mi300_1` 分片，label 以 `· Shard %N/%t` 结尾；分片只能经 pytest-shard 旗标 `--num-shards=$$BUILDKITE_PARALLEL_JOB_COUNT`、`--shard-id=$$BUILDKITE_PARALLEL_JOB` 实现，pytest 选择面保持不变（单卡 marker 表达式、`--run-level "core_model"`、`--durations=0`、`-v`、`-ra`）；junit XML、tee 的 log 与 `tail -n 100` 生成的 summary 三类工件文件名都必须嵌入 `$${BUILDKITE_PARALLEL_JOB}-of-$${BUILDKITE_PARALLEL_JOB_COUNT}` 后缀，使并发分片互不覆盖；保留 `timeout --signal=TERM --kill-after=2m 45m` 命令超时（为 summary 工件留约 5 分钟）、`timeout_in_minutes: 50`、`grade: NonBlocking`、`mirror_hardwares: [amdproduction]`、`depends_on: amd-build`，以及 fail-closed 语义：该步骤恰好一条 pytest 命令、无 `--collect-only`、无 `VLLM_CI_ALLOW_NO_TESTS`。结构必须由 `tests/buildkite/test_amd_ready_r2_01.py` 回归守护：断言 `parallelism == 2`、argv 含两个分片旗标与 `-v`/`-ra`/`--durations=0`、三类工件名带分片后缀、单条 pytest 命令、fail-closed 旗标缺失与 45m/50m 超时。动机（PR #9227 记录的实测）：单作业选中 1,811 个用例需 pytest 34m21s、作业 35m05s（build 14388）；双分片实测 19m01s/21m35s、关键路径 22m22s，且两个 AITER MHA kernel 在每个干净 worker 上独立编译（253-254s 与 275-278s），分片不会摊薄每分片的编译成本。 |
There was a problem hiding this comment.
For future PR learning, this paragraph permanently records PR #9227's selected-test count, build number, shard runtimes, critical-path duration, and kernel compilation timings. These are one-off result data rather than executable instructions and will become stale while appearing to be part of the active contract; retain the actionable sharding and timeout requirements plus provenance, but remove the embedded run report.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-5ca7b46858fb).repos/vllm-omni/rules-amd-ci.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.