Repository navigation
knowledge(vllm-omni): 2 change(s) from intake - #399
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a6bf1988b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 禁止：在 INFO 日志中写入原始 `text` 或 `prompt`；无条件输出 DEBUG 用户内容；使用固定预览长度替代请求日志开关；在未配置 `max_log_len` 时输出无界用户输入。 | ||
| - 验收：覆盖 TTS、diffusion TTS、audio generation 和 diffusion chat，断言 INFO 不含用户内容；启用 `--enable-log-requests` 时 DEBUG 才输出内容，且配置与未配置 `max_log_len` 时均遵守截断上限。 ^[PR #6329] | ||
|
|
||
| ## VLLM-OMNI-PR9282-DUPLEX-APPEND-GATE — 全双工响应门只统计未完成的 response-bound append 任务 |
There was a problem hiding this comment.
Rename this rule to the page's auditable SERV-<number><letter> form. knowledge/tools/check_review_report.py only extracts IDs matching [A-Z][A-Z0-9]*-\d+[a-z]?, and this page itself says only SERV-数字字母 IDs are auditable; because the file already contains other valid IDs, the validator silently omits this new rule rather than reporting that the file has no IDs, so Direct reviews never evaluate the new append-gate contract.
Useful? React with 👍 / 👎.
|
|
||
| ## VLLM-OMNI-PR9282-DUPLEX-APPEND-GATE — 全双工响应门只统计未完成的 response-bound append 任务 | ||
|
|
||
| - 触发：修改 `vllm_omni/engine/duplex/session/context.py` 中 append 任务的跟踪与清理、`has_response_bound_append_tasks` / `cancel_append_tasks`，或 barge-in/VAD 之后新回合的响应门判定。 |
There was a problem hiding this comment.
Move this rule to rules-session-lifecycle.md and update the corresponding route. The serving index explicitly sends deferred gates, barge-in cancellation, response ownership, and session cleanup to that page, which already owns those contracts; a review following that route will not see this rule at the bottom of the generic serving page.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
| `preferred` 重新产生 artifact，`required` 只消费 exact hit。它不扩大 direct checkpoint mmap、 | ||
| online quantization 或 AllGather 的支持范围。^[PR #6486] | ||
|
|
||
| ## VLLM-OMNI-PR8801-H3-NATIVE-PARTITION — 本地 MiniMax-H3 判定必须让 native 分区布局优先于 modular 标记文件 |
There was a problem hiding this comment.
Rename this heading to the model owner's MMH3-<number><letter> namespace and add it to the MiniMax-H3 quick map. The owner entry page states that only MMH3-数字字母 IDs are auditable, while check_review_report.py rejects the hyphenated VLLM-OMNI-PR... shape; existing valid IDs prevent a validation error, leaving this new checkpoint rule silently absent from generated review reports.
Useful? React with 👍 / 👎.
| - 触发：修改 `vllm_omni/model_executor/models/minimax_h3/checkpoint.py` 的 `is_minimax_h3_modular`、`_NATIVE_PARTITIONS`、`resolve_minimax_h3_model_root`/`resolve_minimax_h3_diffusion_model_path`，或本地 checkpoint 的 native/FastH3 modular 判定顺序。 | ||
| - 强制：本地目录必须先按 native 分区判定——`FL2VA/model_index.json` 或 `Ref2VA/model_index.json` 存在即判 native（返回 `False`），之后才检查 `modular_model_index.json`/`fastvideo_inference.json` 标记。依据是官方 `MiniMaxAI/MiniMax-H3` 仓库会在根目录同时携带 `modular_model_index.json` 与 `FL2VA/`/`Ref2VA/` 分区，而 FastH3 modular release 没有分区；误判会让 pipeline init 因找不到 `fastvideo_inference.json` 抛 `FileNotFoundError`。native root 下 encoder resolver 必须返回 `FL2VA/text_encoder`，diffusion resolver 返回 `FL2VA`。Hub ID 走独立分支，不受该本地目录判定影响。 | ||
| - 禁止：仅凭 modular 标记文件存在就把含分区的本地快照判成 FastH3 modular；把没有 `model_index.json` 的空分区目录当作 native 证据；改动判定顺序时影响 Hub ID 分支或破坏既有 FastH3 本地/Hub 检测语义。 | ||
| - 验收：`tests/diffusion/models/minimax_h3/test_fasth3_checkpoint.py` 必须同时覆盖混合根 case（`FL2VA/`+`Ref2VA/`+`modular_model_index.json` 判为 native，且两个 resolver 返回分区路径）与对照 case（仅空分区目录加 modular 标记仍判为 modular），并保持既有 FastH3 本地与 Hub 检测测试全部通过。^[PR #8801] |
There was a problem hiding this comment.
Do not activate this rule until its upstream behavior has landed. At this snapshot, PR #8801 is still open, whereas the configured intake consumes merged PRs and the upstream-fact gate explicitly rejects a cited PR that is not merged (test/test_kb_upstream_facts.py:118-124). Publishing it as active would tell future reviewers to enforce behavior that is not present in the audited upstream main revision and would fail the repository's live-fact publication gate.
Useful? React with 👍 / 👎.
|
Knowledge quality gate · checked 2026-10-23 at Result: not passed. This PR will not be merged until the problems below are fixed; push a fix and it is checked again at the next daily pass. Problems:
|
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-3fd8663177d6).repos/vllm-omni/components/serving/rules.mdrepos/vllm-omni/models/minimax-h3/rules-loading.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.