Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #404
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d314448090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [Diffusion JIT CUDA 构建 include 顺序规则](rules-jit-cuda-includes.md) | ||
| - [AR-Diffusion 实时模型集成规则](rules-ar-realtime-integration.md) | ||
| - [Diffusion attention dense 4D mask routing](rules-4d-mask-routing.md) | ||
| - [vllm-omni · Diffusion — Wan SDPA 对齐测试规则](rules-wan-sdpa-math.md) |
There was a problem hiding this comment.
Route the Wan SDPA rule through Direct
When a PR changes tests/diffusion/distributed/test_wan_attention_sdpa_alignment.py, direct_review_plan currently either returns the diffusion owner's components/diffusion/rules.md quick map without this rule or, without matching title/body text, returns no route; related_knowledge also excludes rule pages. Because this commit links the new rule only from _index.md, which reviewers must not reopen after an exact route, the MATH/torch.equal guard is never delivered. Add it to the owner rule or its Direct quick map, and route the test path if it must work independently of title/body wording.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-9870bd9c936d).repos/vllm-omni/components/diffusion/rules-wan-sdpa-math.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.