Skip to content

knowledge(vllm-omni): 1 change(s) from intake - #404

Merged
tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-intake-9870bd9c936d
Oct 23, 2026
Merged

tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-intake-9870bd9c936d

Conversation

@tzhouam

@tzhouam tzhouam commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Generated automatically by the Copilot knowledge service (changeset vllm-omni-intake-9870bd9c936d).

op page rule
add repos/vllm-omni/components/diffusion/rules-wan-sdpa-math.md VLLM-OMNI-PR9303-WAN-SDPA-MATH

Generator: zcode:GLM-5.3 · judge: codex:gpt-6-sol:medium.
The publisher merges it only if its local gate passes on the exact merge result.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T17:19:32.420874Z d314448 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tzhouam
tzhouam merged commit 9651afc into main Oct 23, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d314448090

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- [Diffusion JIT CUDA 构建 include 顺序规则](rules-jit-cuda-includes.md)
- [AR-Diffusion 实时模型集成规则](rules-ar-realtime-integration.md)
- [Diffusion attention dense 4D mask routing](rules-4d-mask-routing.md)
- [vllm-omni · Diffusion — Wan SDPA 对齐测试规则](rules-wan-sdpa-math.md)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route the Wan SDPA rule through Direct

When a PR changes tests/diffusion/distributed/test_wan_attention_sdpa_alignment.py, direct_review_plan currently either returns the diffusion owner's components/diffusion/rules.md quick map without this rule or, without matching title/body text, returns no route; related_knowledge also excludes rule pages. Because this commit links the new rule only from _index.md, which reviewers must not reopen after an exact route, the MATH/torch.equal guard is never delivered. Add it to the owner rule or its Direct quick map, and route the test path if it must work independently of title/body wording.

AGENTS.md reference: knowledge/AGENTS.md:L16-L16

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant