Skip to content

knowledge(vllm-omni): 1 change(s) from intake #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tzhouam merged 1 commit into from
Oct 23, 2026
Merged

knowledge(vllm-omni): 1 change(s) from intake #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions knowledge/repos/vllm-omni/components/serving/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,4 @@ sources: []
- [视频 timeline guides 规则](rules-timeline-guides.md)
- [vLLM-Omni 服务：Gradio 示例 PCM 音频转换规则](rules-gradio-pcm.md)
- [vLLM-Omni Serving：Seed-TTS 基准与准确率规则](rules-seed-tts.md)
- [vLLM-Omni Stage-CLI 测试规则](rules-stage-cli-tests.md)

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add this rule to the Direct serving entrypoint

For a future PR that edits tests/helpers/runtime.py, Direct review supplies the canonical serving owner document components/serving/rules.md and stops before reading this _index.md; related-knowledge retrieval also excludes rule pages. Because this commit links the new page only here and rules.md has no Stage-CLI trigger or link, the rule will not reach the normal review evidence packet. Add it to the rules.md quick map or merge the rule into that entrypoint so the intake is actionable.

AGENTS.md reference: AGENTS.md:L12-L17

Useful? React with 👍 / 👎.

19 changes: 19 additions & 0 deletions knowledge/repos/vllm-omni/components/serving/rules-stage-cli-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
title: "vLLM-Omni Stage-CLI 测试规则"
created: 2026-10-23
updated: 2026-10-23
type: rule
tags: [vllm-omni, components, serving]
sources: ["PR #9041"]
---

# vLLM-Omni Stage-CLI 测试规则

## VLLM-OMNI-PR9041-STAGE-CLI-GPU-SPLIT — Stage-CLI 多副本 stage 每 stage 单进程并用 --omni-dp-size-local 分卡

- 触发：修改 `tests/helpers/runtime.py` 中 `OmniServerStageCli` 的启动路径（`_build_stage_cmd`、`_launch_stage`、`_start_server`）或 `stage_procs`/`_stage_log_paths`/`_stage_log_files` 簿记；调整 stage-CLI e2e 多副本 overlay（如 `bagel_multi_replicas_4gpu`，PR 时唯一 `num_replicas > 1` 的 stage-CLI overlay）的副本放置。
- 强制：headless stage 只按 `stage_id` 启动一个进程；当 `stage_replica_counts[stage_id] > 1` 时，命令必须追加 `--omni-dp-size-local <num_replicas>`，由 `serve` 的 headless 分卡把 stage `devices` 池（如 `1,2,3`）拆成每副本一张物理卡。簿记以 `stage_id` 为键，日志名为 `omni_stage_<id>_<port>.log`；改键结构时确认只遍历 `.values()` 的其他读者（如 `test_gepard_tts.py`）不受影响。此类放置问题在 harness 侧修复并对齐生产 headless 分卡（`stage_engine_startup.py`，文档 `docs/design/module/stage_runtime.md`），不为此改生产代码。
- 禁止：向 stage-CLI 命令传 `--replica-id`（`serve` 忽略该已弃用参数），或为每个副本各起一个 headless 进程——每个进程会以 `omni_dp_size_local=1` 落到 local device 0 的同一张物理卡，多副本叠放显存导致 OOM（#6843 的故障模式）。
- 验收：`tests/helpers/tests/test_runtime_stage_cli.py` 断言：多副本 stage 命令含 `--omni-dp-size-local N` 且无 `--replica-id`；单副本 stage 省略该参数；`_start_server` 对每个 stage 只启动一个进程。^[PR #9041]

<!-- kb:rule status=active since=v0.30.0 -->
Loading