Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #406
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0cd87e2c6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| <!-- kb:rule status=active since=v0.30.0 --> | ||
|
|
||
| ## VLLM-OMNI-PR9304-EDGE-PP-OWNERSHIP — Edge 权重校验必须从活模块读取 PP 归属 |
There was a problem hiding this comment.
Rename this rule to an unused COSMOS-<number><letter> ID. This page explicitly declares that only IDs in that format are auditable, so VLLM-OMNI-PR9304-EDGE-PP-OWNERSHIP cannot be referenced or counted as a structured Cosmos3 rule and must otherwise be treated as legacy-unstructured knowledge.
Useful? React with 👍 / 👎.
| ## VLLM-OMNI-PR9304-EDGE-PP-OWNERSHIP — Edge 权重校验必须从活模块读取 PP 归属 | ||
|
|
||
| - 触发：修改 `vllm_omni/diffusion/models/cosmos3/transformer_cosmos3_edge.py` 的 `validate_loaded_weights` 或 `_weight_marker_is_pp_missing`，或在仓库模型代码中引入上游 `is_pp_missing_parameter` 的权重归属判定。 |
There was a problem hiding this comment.
This adds a new Edge PP weight-validation rule without updating the nearest _index.md, leaving the owner overview and its “when to check here” section stale for this trigger. Update that index in the same change so readers entering through the documented owner-navigation path can discover the new rule.
AGENTS.md reference: knowledge/AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-d0bbcca25a29).repos/vllm-omni/models/cosmos3/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.