Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #409
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a94ee2eb36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## VLLM-OMNI-PR8868-QWEN21-VAE-TILE-STARTS — VAE tiled decode 的 tile 起点必须均匀铺开且尾 tile 贴边结束 | ||
|
|
||
| - 触发：修改 Qwen-Image-2.1 VAE 的 tiling/tile 布局——`vllm_omni/diffusion/models/qwen_image_21/autoencoder_kl_qwenimage21.py` 的 `_tile_starts`、tiled decode 循环或 `tile_sample_min`/`tile_sample_stride` 语义，或 `vllm_omni/diffusion/distributed/autoencoders/autoencoder_kl_qwenimage21.py` 的 `tile_split`/`tile_merge` 与 `tile_spec` 中的 `starts_*`/`overlap_*`/`cells_per_latent` 字段。 | ||
| - 强制：轴向 tile 起点必须统一由 `_tile_starts(size, tile_min, stride)` 一类布局产生，并保持不变量：首起点为 0、严格递增、尾 tile 恰好在边界结束（`starts[-1] == size - tile_min`）、相邻间距落在 `[1, stride]` 且整数网格内尽量均匀（max-min ≤ 1）、轴尺寸 ≤ tile_min 时单 tile 覆盖；每个 tile 都保持完整 decode window。分布式 `tile_split` 的 overlap 必须由相邻起点的实际差值乘 `cells_per_latent`（`spatial_compression_ratio // (patch_size or 1)`，unpatchify 前的折算）推导并写入 `tile_spec`，`tile_merge` 从 `tile_spec` 读回同一组 starts/overlap，grid 形状等于两轴起点数、坐标使用起点索引。 |
There was a problem hiding this comment.
When adjacent starts are not half a tile apart, the prescribed calculation produces the tile spacing rather than the overlap. For example, with tile_min=8 and starts [0,5,10], adjacent tiles overlap by 3 latent cells, not 5. The overlap should be (tile_min - (starts[i] - starts[i-1])) * cells_per_latent. Following the current mandatory rule would give distributed blending/merging incorrect overlap widths. The acceptance example [0,4,8] masks the error because its spacing and overlap happen to be equal.
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-91016ea6e012).repos/vllm-omni/models/qwen-image/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.