Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #410
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69bb4f9303
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## VLLM-OMNI-PR9320-ROCM-SELECT-PREFLIGHT — AMD CI GPU lane 必须用显式 ROCm 选择器并预检精确收集数 | ||
|
|
||
| - 触发：修改 `.buildkite/amd/test-amd-ready.yml` / `test-amd-merge.yml` 的 GPU lane pytest 选择器、`.buildkite/amd/scripts/assert-pytest-collection.sh`、`tests/buildkite/` 的 lane 断言，或测试文件上的 `rocm`/`cuda`/`nvidia_only`/`MI325`/`cards_N` 平台标记与 `tests/helpers/tests/test_check_test_marks.py` 的静态标记检查。 |
There was a problem hiding this comment.
For changes to AMD pipeline selectors or shared marker validation, this rule is stored under the wrong owner: its trigger covers shared Buildkite infrastructure and multiple models, not Qwen3-TTS implementation. The repository’s routing table sends Buildkite/hardware-lane reviews to ci/rules.md, while existing AMD pipeline contracts live in rules-amd-ci.md; neither routes readers to this new section. Consequently, CI-focused reviews following the prescribed owner-scoped navigation will miss the new collection and marker safeguards. Move the shared contract to the CI/AMD owner and update its routing, retaining only model-specific constraints or a link here. This violates the nearest-owner requirement in root AGENTS.md.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-11da117e84e2).repos/vllm-omni/models/qwen3-tts/rules.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.