Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #413
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15382002b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## VLLM-OMNI-PR9339-WAITER-EXIT — Host Weight Runtime 等待进程收尾与 0.1 秒域锁协调期限分离：60 秒完成 / 5 秒清理双上限 | ||
|
|
||
| - 触发：改动 `tests/host_weight_runtime/test_runtime_resolution.py` 中 `test_domain_lock_timeout_and_fresh_runtime_recovery` 的子进程收尾结构：`_PROCESS_COMPLETION_TIMEOUT_SECONDS`（60 秒）、`_PROCESS_CLEANUP_TIMEOUT_SECONDS`（5 秒）、`_CONTROLLED_FINALIZATION_DELAY_SECONDS`（8 秒）三个常量，`_initialize_contended_runtime` 的 `finalizing` 握手与受控收尾延迟参数，或正常完成与强制清理两条 `join` 路径的超时取值与断言。本规则只覆盖该测试文件的结构契约；Host Weight Runtime 本体行为不在范围内（PR #9339 为 test-only 改动）。 |
There was a problem hiding this comment.
This rule exclusively targets tests/host_weight_runtime/test_runtime_resolution.py, but it is stored and indexed under Model Executor. At the reviewed commit, adapters/vllm_omni/manifest.yaml:156–158 explicitly assigns tests/host_weight_runtime/ to the host_weight_runtime owner, whose knowledge entry already exists at components/host-weight-runtime/rules.md. Keeping the rule here makes owner-scoped reviews of those tests miss the new regression guidance. Move it into that owner's rule page and update the corresponding index rather than routing it through Model Executor; root AGENTS.md requires PR learning to remain with the nearest code owner.
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-9d3b8239a90c).repos/vllm-omni/components/model-executor/rules-host-weight-runtime.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.