Repository navigation
knowledge(vllm-omni): 1 change(s) from intake - #415
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28fb6768be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## VLLM-OMNI-PR9344-MINICPM-ATTN-COMPARE — MiniCPM-o 注意力后端对比：出货 profile 不锁定 CUDA Thinker 后端，实验走仅改 stage 0 的 overlay | ||
|
|
||
| - 触发：改动 `docs/serving/realtime_duplex_api.md` 的 `#### Compare MiniCPM-o attention backends` 小节，或 MiniCPM-o 部署 profile（如 `vllm_omni/deploy/minicpmo_4_5.yaml` 及其变体）中 CUDA stage 的 `attention_backend` 取值，或 `tests/model_executor/models/minicpmo_4_5/test_pipeline.py` 对部署 profile 的结构断言；也覆盖以采样 transcript 差异主张注意力后端缺陷、或以 `response.done` 成功主张识别质量的评审证据。 |
There was a problem hiding this comment.
This rule applies exclusively to MiniCPM-o deployment profiles, backend comparisons, and model-specific tests, but its sole index entry places it under the shared serving component. The existing owner is models/minicpm-o-4-5/, where rules-duplex.md already maintains shipping-profile attention and configuration constraints. Keeping this page under serving splits that model contract across unrelated owners and leaves it absent from the model's own knowledge entrypoints. Move the rule to that model owner and update its nearest index. Root AGENTS.md explicitly requires that “model-specific rules stay with that model owner.”
AGENTS.md reference: AGENTS.md:L12-L14
Useful? React with 👍 / 👎.
Generated automatically by the Copilot knowledge service (changeset
vllm-omni-intake-db1920b95c83).repos/vllm-omni/components/serving/rules-minicpmo-attn-compare.mdGenerator:
zcode:GLM-5.3· judge:codex:gpt-6-sol:medium.The publisher merges it only if its local gate passes on the exact merge result.