Skip to content

knowledge(vllm-omni): 1 change(s) from intake - #417

Merged
tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-intake-8102c2478ea9
Oct 25, 2026
Merged

tzhouam merged 1 commit into
mainfrom
kb/vllm-omni/vllm-omni-intake-8102c2478ea9

Conversation

@tzhouam

@tzhouam tzhouam commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Generated automatically by the Copilot knowledge service (changeset vllm-omni-intake-8102c2478ea9).

op page rule
add repos/vllm-omni/models/cosyvoice3/rules.md VLLM-OMNI-PR8456-MULTI-VOICE-BENCH

Generator: zcode:GLM-5.3 · judge: codex:gpt-6-sol:medium.
The publisher merges it only if its local gate passes on the exact merge result.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T17:39:54.239471Z 298c1cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 298c1cbe04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +77 to +79
## VLLM-OMNI-PR8456-MULTI-VOICE-BENCH — CosyVoice3 并发基准必须多 voice 轮转并按 (text, voice) 分组校验 seeded 一致性

- 触发:修改 `benchmarks/tts/bench_cosyvoice3_concurrency_matrix.py` 的 `--ref-audio`/`--ref-text` 参数解析、worker 的 per-request voice 选择、结果字段或固定 seed 的 byte-identity 校验。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the multi-voice benchmark rule to the owner index

The new benchmark rule is added without updating knowledge/repos/vllm-omni/models/cosyvoice3/_index.md. That index still describes rules.md only in terms of TensorRT stream handoff and plan publication, with deployment and HiFT additions; it does not advertise multi-voice concurrency or seeded identity checks. Readers selecting knowledge through the owner index therefore have no indication that this benchmark contract lives here. Update the index routing description in the same change, as explicitly required by the root AGENTS.md.

AGENTS.md reference: AGENTS.md:L23-L24

Useful? React with 👍 / 👎.

@tzhouam
tzhouam merged commit 5720d19 into main Oct 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant