Skip to content

Learn owner rules from human reviews - #94

Merged
TaffyOfficial merged 2 commits into
mainfrom
agent/human-review-learnings
Aug 23, 2026
Merged

TaffyOfficial merged 2 commits into
mainfrom
agent/human-review-learnings

Conversation

@TaffyOfficial

Copy link
Copy Markdown
Contributor

Summary

抽样对照线上 ReviewBot jobs 与 GitHub 真人 review:#6478、#6161、#6311、#6468、#6445,并补充检查有实质真人 finding 的 #6385、#6138。

沉淀 3 条 owner-scoped 规则:

  • Diffusion artifact identity:共享 ABI 与具体 dtype/layout 解耦;仅验证过的不可变 Hub blob 可跳过内容哈希。
  • Diffusion 异常清理:raise、错误回复和 rank-status envelope 都必须释放 traceback/device cache。
  • Serving 构造状态:共享服务类重构必须覆盖普通、无 adapter、diffusion/bypass-init 等生产构造路径。

#6311 的 CI 意见存在明确语境分歧,#6468 只有 approve,#6161/#6478 没有新增真人 finding,因此未硬泛化进规则。

Validation

  • python knowledge/tools/check_knowledge_tree.py
  • python knowledge/tools/check_wiki_lint.py
  • python tools/audit_vllm_omni_release.py --from 5d44868e... --to 807db6ef... --repo <upstream-checkout> --project-root <this-repo> --mode enforce
  • $env:PYTHONPATH='src'; python -m pytest test/test_imupdate_skill.py -q
  • git diff --check

@TaffyOfficial
TaffyOfficial merged commit 1a050ea into main Aug 23, 2026
3 checks passed
@TaffyOfficial
TaffyOfficial deleted the agent/human-review-learnings branch August 23, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants