Skip to content

Skill Eval: automate PR evaluation planning and feedback #101

Open

Description

@Dong1017

Parent: #88 · Delivery 3 of 3 · Depends on #100's local comparison/report contract

Connect the local evaluator to skill PRs without making maintainers copy reports.

flowchart LR
    A[PR change] --> B[Plan]
    B --> C[Authorize]
    C --> D[Evaluate]
    D --> E[PR report]
    F[New revision] --> B
Loading

Planned increment

Capability Required behavior
Automatic planning Identify changed skills/resources using a small maintained case mapping. Show selected cases, uncovered changes and estimated calls/limits; planning makes no model calls.
Authorized execution Bind each execution to explicit approval of the frozen plan, PR head, compared revisions and budget. A new revision requires renewed authorization.
Automatic feedback Generate/update one identifiable PR summary with outcome differences and evidence links. No manual report copying.
Freshness and retry Mark old results stale after relevant input changes. Duplicate triggers do not duplicate paid work; publication retry reuses results without reevaluation.
Separation Execute untrusted PR content without publication credentials; use trusted code to publish validated report data.

Detailed trigger, authorization and artifact-retention choices should be finalized against the delivered local comparison interface, not by adding a new orchestration platform now.

Close when

  • A skill addition and an update select the appropriate comparison; unmapped changes are visibly uncovered, never passed.
  • New head/plan changes invalidate prior authorization/results; stale jobs cannot replace a current report.
  • Offline integration tests cover duplicate triggers, publication failure/retry and untrusted report handling without real model calls.
  • The tool publishes a revision-bound PR report automatically from retained evidence, with a documented retention window.
  • The parent Skill Eval v1.1: automated evaluation for skill additions and updates #88 end-to-end exercise covers one addition and one update with separately authorized real-agent execution and automatic PR feedback. Neutral or negative results are valid outcomes.
  • Closure records a concise change diagram, verification receipts and remaining limitations.

Boundaries

Report-only integration, not a required efficacy gate or automatic merge/promotion. Authorship admission remains separate. No new skill-version fields, manual result ledger, dashboard, runner, or automatic evaluation of local Create/Update. Issue creation grants no model budget, credentials or repository-security changes.

Activity

  1. added
    area:knowledgeKnowledge line: packs, skill library, knowledge admission
    on Oct 23, 2026
  2. Dong1017 commented on Oct 23, 2026

    @Dong1017
    CollaboratorAuthor

    Next delivery after #109

    The local comparison implementation is now on main at 48e0d58. #100 is accepted and closed with explicit owner confirmation (2026-10-23); its offline closure evidence is recorded. #101 is now the remaining implementation slice under #88.

    Step Reuse / bounded increment
    Preflight Read tools/skill_eval_compare.py and docs/skill-eval-comparison.md at the merged revision; identify the existing plan hash, execute and report interfaces before designing glue.
    Plan Small maintained skill/resource-to-case mapping; PR change → existing addition/update plan. Show uncovered changes and estimated limits. Zero model calls.
    Execute Explicit authorization for the exact frozen plan/revisions/budget. Reuse the existing runner; duplicate triggers must not create duplicate paid work.
    Publish One identifiable revision-bound PR summary from retained JSON/Markdown; stale results cannot overwrite current ones; publication retry must not rerun evaluation.
    Verify Offline fixtures first: addition/update/uncovered changes, stale inputs, duplicate triggers, publication failure and untrusted report data. Separate execution from publication credentials.

    No new runner, skill-version registry, dashboard or required efficacy gate. Keep the PR-facing layer thin. Real-agent addition/update end-to-end exercises still require a separately fixed budget and authorization; this comment grants neither paid execution nor new credentials/settings. #88 remains open.

  3. added
    kind:taskBounded delivery task with a delegated slice
    on Oct 23, 2026
  4. Dong1017 commented on Oct 25, 2026

    @Dong1017
    CollaboratorAuthor

    Issue owner and remaining delivery plan

    Acting Issue-level owner: Codex, the agent continuing #101 across its delivery PRs, under the user's explicit delegation. Preserve the three implementation workstreams under #88. #101/#88 remain open until their real addition/update flows and automatic feedback satisfy acceptance and the human owner decides.

    Current delivery head: #118 at c716307df7c9dbd0674638ecea894bd912790882, branch codex/issue101-pr-skill-eval, Ready, unmerged and mergeable. Main snapshot merged into it is ea7ab7dae50c8c943fac54ca4a16b58f4402ab67. Later main increments 0cffd207 / a8e4c572 are knowledge guidance/projections with no file overlap with the ten-file integration increment; reassess main immediately before any future merge.

    Acceptance / delivery slice Current evidence Remaining action
    Skill/resource selection, addition/update comparison and visible uncovered changes #118's thin adapter, maintained mapping and offline controls Integrate after the current-head review and all applicable checks pass; then prepare actual trial PRs using trusted main
    Revision-bound approval, duplicate rejection, stale results and publish-only retry Existing #118 controls remain; final-head Ready CI passed all four jobs Preserve the contracts; remote CI is software evidence, not real-flow acceptance
    Compatible main integration Merge de54da1 preserves both operation-table entries; #145 is already merged as ea7ab7d and #146 as 6c426e8 by their respective integration owners No duplicate conflict repair or #146 takeover is needed
    Strict result-artifact import Current-head correction validates original ZIP names before platform normalization; the existing fixture preserves raw unsafe spelling. Local first run: 47 passed / 1 failed; raw backslash reproduction failed before the fix; all 8 archive-path cases and Ruff passed after it Independent final-head review requested; prior LGTM only covered f1c422c
    Automatic feedback from retained real results #118's trusted source-run/artifact validation and publisher Confirm usable authorized runtime connected to automatic publication; manual outcome copying is insufficient
    One real addition and one real update Both source candidates are prepared offline with canonical registration/projections and mechanical checks Resolve truthful knowledge authorship admission and runtime prerequisites, create actual PR identities and freeze both plans before separate exact execution approvals
    Whole-Issue acceptance Current #101/#88 checklists Verify both actual flows and reports before proposing acceptance; neutral/negative results are valid

    Current integration gate: per-head knowledge-model-policy is success / Not applicable, but associated aggregate declarations jobs are cancelled. This is not a claim that all applicable checks pass. The earlier independent software LGTM covered the old f1c422c head and is retained as history, not approval for this new delta. No reviewer-role approval has been authored by this Issue owner.

    The human permits an expected-head squash merge of #118 only when genuine independent current-head Dong1017 LGTM, every applicable current CI/check/status and integration conditions all hold. Do not auto-merge, bypass checks or treat a green per-head status as clearance of an unresolved applicable workflow result. #145 is already merged; do not repeat that operation.

    Next action: obtain independent review for the current full head, address any new actionable finding in this same PR and inspect current CI. Continue actual trial-subject planning only when trusted-main workflow/mapping, runtime/automatic feedback and truthful author admission are usable. There is no additional execution authorization, new runner, credential/security change, fourth evaluator workflow or Issue closure in this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:knowledgeKnowledge line: packs, skill library, knowledge admissionkind:taskBounded delivery task with a delegated slice

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions