Repository navigation
Conversation
Extend the existing stable-diffusion.cpp residency owner with bounded catalog identity, byte delivery, staging, and mapping cleanup guidance. Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Bind the shared projection to the committed loader and storage extension without changing unrelated knowledge semantics. Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the bounded source-derived candidate scope at eb271d3844a21f9b9852a8b7a106dfa2441a142e (base 48e0d5894117be7c57f8b4ce793c0ec986f219e8). No actionable findings.
The sampled pinned loader/consumer implementations support the catalog-identity versus byte-delivery distinction, short-read propagation, callback-before-delivery ordering, loaded-state publication and cleanup guidance. The existing eight-step residency procedure is preserved; the loader case is additive and remains candidate/not_run. Source commit cdffd9475a0db4c4481a78e0e819a59b28b12dcb is the parent of the projection-only refresh; unrelated generated records change only source URL/commit.
Ready CI: all four full-check/clean installed-package jobs passed on Python 3.10/3.11; current knowledge-model-policy status is successful. These are inspected GitHub CI results, not tests rerun here.
Verification was read-only source, diff, packaging-rule and projection inspection, not an independent recomputation of every source hash or native/hardware/model/agent-efficacy execution. Parallel knowledge contributions share generated discovery records: preserve all canonical changes and regenerate from the combined source commit during integration. This is a future integration requirement, not a present inventory defect. #91 remains a living tracker; LGTM is not empirical qualification or tracker acceptance.
Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Preserve canonical source and validation boundaries. Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Preserve canonical source and validation boundaries. Signed-off-by: GUOGUO <xwdong1998@163.com> Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author)
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the bounded integration delta at b744943dbc2a419406cdbc1f67415b0eef1cdd2a, reported base 65147a03e465dc838770474736a620e04d72337e. No actionable findings beyond the stated verification limits.
All eight stable-diffusion.cpp owner files retain reviewed Git blob identities. Current-main content is preserved outside scoped loader/storage and owner matrix additions; runtime, generator and tests match main. Combined source d959487ab1d0b2b27fad6792ef15d91f3c91674a → head changes only generated files: other 58 records change only provenance, and the SD record retains reviewed semantics. GitHub reports mergeable.
All four exact-head Ready full-check/clean-wheel jobs pass on Python 3.10/3.11; per-head knowledge-model-policy succeeds. This does not clear the separate aggregate/history failure tracked in #140.
Read-only prior-review/delta/Git-identity/projection/test-diff and CI inspection. No PR code, tests, generator or native/model experiments executed, no exhaustive source-hash recomputation and no new backend/quality/performance/agent-efficacy qualification. Previous candidate/not_run and hardware-coverage limitations remain; issue acceptance and merging are separate.
Preserve the loader and storage source extension with all current main knowledge increments. Keep main generated projections for regeneration from this combined source commit. Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author) Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Refresh discovery records from the actual combined source revision. Verify committed source hashes and actual package resource and context reads. Agent-assisted-by: Codex / gpt-6.1-sol [effort=xhigh] (author) Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Dong1017
left a comment
There was a problem hiding this comment.
Scoped LGTM for the integration delta at 0cae446eab33645eca962374cda2ecbe34bbbe3b, reported base 5b939a95d7478b1d8bff013c477972903b7de9ba, compared with previously inspected b744943dbc2a419406cdbc1f67415b0eef1cdd2a. No new actionable source/integration finding.
All eight stable-diffusion.cpp owner blobs and the original source report are unchanged. Current-main content is preserved outside the original loader/storage additions; runtime/generator/tests match main. Combined source 0e5d063 to head changes only projections; other 59 records change provenance only.
Exact-head Ready CI has four successful full-check/installed-package jobs; lint also passes. Fresh per-head policy: success, source https://github.com/InferMatrixLab/InferRSI/actions/runs/40271581200. Aggregate declarations failures/cancellations are separate and are not claimed green. Head and mergeability were refreshed before posting (mergeable=true); recheck required gates and the resulting integration tree before any merge.
Source-derived candidate/not_run boundaries remain; this does not validate a runtime/model/hardware combination.
Read-only incremental source/blob/projection/caller/test-assertion and existing discussion/CI inspection. No PR-code execution, generator rerun, model/GPU experiment, thread resolution or Issue acceptance. This records the new inspected head without reopening resolved findings or repeating the upstream audit.
Reviewer: dot / OpenAI assistant; exact runtime model identifier is not exposed.
Dong1017
left a comment
There was a problem hiding this comment.
LGTM within this PR's accepted source/software scope. Meaningful CI-blocker clearance on unchanged head 0cae446eab33645eca962374cda2ecbe34bbbe3b: Ready CI and declarations rerun are successful; exact-head knowledge-model-policy is success. This updates the prior scoped review rather than reopening resolved findings.
Integration inspected against actual main db82ec8346364667b90f4fa97fdb190150141cf0, separately from the PR API's base snapshot 5b939a95d7478b1d8bff013c477972903b7de9ba. The intervening #154/#118 changes (18 paths) do not overlap this contribution. New evaluation-planner mapped canonical directories are not changed by this PR; its source delivery is not thereby covered by a real efficacy evaluation. No new actionable integration finding or unresolved review blocker was identified.
Verification limits: incremental source/integration/prior-thread and CI inspection, no new local tests or model/hardware execution. Existing source-fidelity/packaging conclusions retain their original limits; this is not goal/campaign acceptance or issue closure. Recheck exact head, applicable checks and integration immediately before any merge, especially after another knowledge PR changes shared matrices/projections. Historical red runs remain historical, not rewritten evidence.
Preserve both canonical knowledge histories before rebuilding generated records. Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Build the native projection from canonical source 17b404a. Agent-assisted-by: Codex / gpt-6.1-sol [effort=max] (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the repaired source/package integration at head 7688d7a5618cba2757a8435c036ce7a18e82b164, incrementally compared with previously inspected 0cae446eab33645eca962374cda2ecbe34bbbe3b.
All eight SD owner resources and original report remain unchanged. Main's Diffusers consolidation and canonical content are preserved; runtime, generator and tests retain main's versions. Source 17b404a018fe2c0d5c6457c4fc31ad641f884f5d → head changes generated projections only; the other 59 records change provenance only. Independently checked source Diffusers procedure/registry hashes against projections. The previous merge-conflict blocker is cleared (mergeable=true); no new finding.
All four Ready jobs and current declaration compliance pass. Skill Eval publisher failed; retain its separate operational follow-up.
Integration boundary: inspected actual main 0c78a7e257dfaa3573b77581a39539e8a3a5da4c; the API base remains a4a0fbd62defe2bc53ab090e1fa50bd7139663a6. Their difference is four disjoint Flare #155 paths. This is a scoped source/software conclusion, not an all-workflows-green, model/hardware efficacy, issue acceptance or merge authorization. Separate Skill Eval publication remains failed and execution skipped; do not treat those as a successful evaluation. No model/device calls, installation or workflow dispatch was performed.
Dong1017
left a comment
There was a problem hiding this comment.
Integration-status update only at unchanged inspected head 7688d7a5618cba2757a8435c036ce7a18e82b164 (PR API base snapshot a4a0fbd62defe2bc53ab090e1fa50bd7139663a6). Actual main is 38d5883b8e72e352865e214194cb22dc99253dbd; GitHub now reports mergeable=false / dirty. The prior source-scope review remains valid historical evidence, but is not current integration clearance.
Before merge, reconcile this branch with current main, preserve both accepted contributions, regenerate affected projections only where source-binding rules require it, and verify packaging plus applicable checks on the resulting head. No conflict-file attribution is made without a merge reproduction; no new content/feature requirement is introduced. This is not a new HTTP403 finding: shared publisher recovery was verified separately. No code execution, branch change, workflow dispatch or merge was performed by this review.
Refs #91.
Retain the stable-diffusion.cpp loader and storage-residency candidate pinned to
b13a48219d5cdf408edcb93da6cd69b612ed03d3, including all eight owner resources, inherited MIT license, original readsets, candidate state and empiricalnot_run.Reconcile the published head
0cae446eab33645eca962374cda2ecbe34bbbe3bwith frozen canonical maina4a0fbd62defe2bc53ab090e1fa50bd7139663a6. Canonical source17b404a018fe2c0d5c6457c4fc31ad641f884f5dhas exactly those two parents; generated child and current head7688d7a5618cba2757a8435c036ce7a18e82b164has the source commit as its sole parent. The repair preserves current-main content, all existing contribution content and matrix additions, including Hopper, MLX and Ascend material. Existing intake-to-candidate matrix replacements remain the original contribution's changes.Unchanged stock
tools/build_skill_index.py --source-revision 17b404a018fe2c0d5c6457c4fc31ad641f884f5dand its matching--checkpassed. All 60 generated records bind 269 indexed hashes to committed source bytes. Native catalog, package, resource and bounded context reads passed against the explicit checkout. Other records retain current-main semantics apart from InferRSI provenance and applicable shared-registry hashes. These checks add no upstream runtime, backend/device/model, quality, performance or agent-efficacy result. Current-head independent review and clean installed-package Ready CI remain separate publication checks.Current-head verification at
7688d7a5618cba2757a8435c036ce7a18e82b164: an independent gpt-6.1-sol/ultra review found no actionable issues. All four Ready jobs (Python 3.10/3.11 full checks and clean installed-package checks) and lint-and-smoke passed. The automatic evaluation-report publisher failed with HTTP 403 from the GitHub API; its execution job was skipped. Declaration compliance is a separate status in the current-head checks.