Repository navigation
docs: guide stalled optimization from whole-system bottlenecks - #156
david6666666 wants to merge 3 commits into
Conversation
Signed-off-by: david6666666 <530634352@qq.com>
Signed-off-by: david6666666 <530634352@qq.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: david6666666 <530634352@qq.com>
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the bounded knowledge/generator change at head 6eca16c190cfe4eca6b10be3646ea1589c204382; no actionable source/software finding after reviewing all 24 changed paths against #131's accepted scope and existing discussions.
Reviewed the three diagnosis-first cards, five new versioned cases plus existing admission/drain observation, metadata/notices/matrices, reader/collect fixtures and installed-package assertions. Also reviewed generator --skill, full-regeneration compatibility, per-record source rendering, unknown/empty selectors and stale backend-move rejection. Canonical bytes are pinned to source d0338d7…; all 59 unrelated generated records are untouched. Sampled original Sarathi/PagedAttention/SGLang/DistServe/vLLM/CUDA sources support the stated prerequisites and negative outcomes; hypothetical reversals and candidate/not_run limits remain explicit.
All four Ready jobs, lint and current per-head policy pass. Skill Eval publisher fails HTTP 403 (log inspected); execution skipped.
Outstanding integration decision: #156 and #133 overlap as alternative #131 deliveries, including the same foundational guide path and different case sets. This LGTM is not a recommendation to merge both independently: select/reconcile the delivery before integration and refresh any changed head/projections. No new feature requirement is being added.
Integration boundary: inspected actual main 0c78a7e257dfaa3573b77581a39539e8a3a5da4c; the API base remains a4a0fbd62defe2bc53ab090e1fa50bd7139663a6. Their difference is four disjoint Flare #155 paths. This is a scoped source/software conclusion, not an all-workflows-green, model/hardware efficacy, issue acceptance or merge authorization. Separate Skill Eval publication remains failed and execution skipped; do not treat those as a successful evaluation. No model/device calls, installation or workflow dispatch was performed.
When local optimization plateaus, the existing search policy now directs the agent to reconstruct useful work, dependencies, state ownership and constrained resources across the whole request path before proposing another experiment. Three decision cards cover admission versus preemption, allocation/reuse versus tiering, and pipeline bubbles versus communication/memory pressure. Missing diagnostic evidence calls for measurement or no change.
Refs #131. Issue acceptance and closure remain separate.
optimization-search-policy, existing engine/hardware owners, Orca/Alpa material, andcase.admission-drain-occupancy. Add five versioned cases: Sarathi chunk budgets, PagedAttention allocation, SGLang/vLLM prefix reuse, DistServe placement, and CUDA copy overlap.build_skill_index.py --skill optimization-search-policyscopes generation/checking to that record and shared navigation. All 59 unrelated JSON records are byte-for-byte identical to the PR base; the net diff is 24 files instead of 81. Complete content/hash validation remains per record, using each record's own source pin. Empty/unknown selectors fail, and obsolete projections for a moved skill require explicit removal.Validation:
6eca16c190cfe4eca6b10be3646ea1589c204382; no remaining actionable findings.Regeneration for the affected source:
All commits carry DCO sign-offs. CPU fixtures establish packaging and deterministic retrieval/selection contracts, not agent efficacy or speedup; the existing Skill Eval report-audit grader is unchanged. Complete required Collect context is 206,597 bytes in this snapshot; smaller budgets explicitly return
context_limitandrequired_bytesrather than dropping prerequisites.