[Dong1017]

Governing Issue and delivery slice

Refs #17

• Accepted scope / delegation: RFC [RFC] Knowledge Base v1: Skills, Knowledge, and Internal Experience #17 K2 write slice. Implemented by the Issue's accountable parent agent (Cursor Agent, Claude Opus) acting under @Dong1017; implementation, PR and squash-merge delegation are recorded on [RFC] Knowledge Base v1: Skills, Knowledge, and Internal Experience #17. Issue acceptance and closure are not delegated.
• What this PR delivers: KnowledgeStore (src/omnirsi/knowledge_store.py, docs/knowledge-store.md): Create/Update of supplied store-owned candidate bundles in one existing, explicitly authorized local SQLite store; store:<id> refs combined with the read-only adapters from feat: add normalized knowledge reads and bounded Collect #24; rejection of IDs owned by package/checkout; derived_from adaptations; duplicate-create and stale-update rejection inside a BEGIN IMMEDIATE transaction; all-or-nothing publication; immutable history with retained resources verified by bundle digest; store Collect.
• What it does not deliver: writes to the installed package, checkouts, evidence or either matrix; promotion; repository export; network/distributed-writer or power-loss guarantees.

Changed artifacts and evidence

Requirement (#17)	Actual change	Check / evidence and result	Remaining gap
Create/Update only in an authorized store; adapters stay read-only	KnowledgeStore, _protected location guard	location/symlink/promotion rejection tests; matrix/evidence invariance test	symlink test skips on Windows (runs in Linux CI); with skill_root=None only the package checkout (pyproject.toml + .git) is guarded — documented
Deterministic identity, no shadowing	adapter-ID reservation, store: refs	collision/ambiguity tests	none found
Duplicate/stale rejection; serialized writers	BEGIN IMMEDIATE + in-transaction expected-revision check	test_concurrent_writers_compare_expected_inside_transaction (trace callback asserts both writers reached the lock before release; 3/3 passes in review)	single local SQLite file only
Complete publication, rollback	single transaction for resources, revision, current pointer	real rejecting SQLite trigger test: no partial revision, current unchanged	none found
Immutable history, old revisions return old bytes	history, read/resource(revision=)	retained-revision and digest tests	none found
Contract doc reflects implemented writes	docs/knowledge-base.md K2 rows/diagram, docs/knowledge-store.md	test_maintained_documentation_links_resolve pass	none found

Checks and dependencies

• Checks actually run: Windows 11, Python 3.13.5, .[dev], PYTHONUTF8=1, on a tree identical to this head: pytest -rs --ignore=tests/test_runtime.py exit 0; ruff check src tests clean; ruff format --check on the K2 files clean.
• Skipped / not run: tests/test_runtime.py excluded (fails and hangs on unmodified main on this Windows host; untouched here). Symlink, numpy and Linux-only tests skip locally. CI on this PR is the Linux reference.
• Independent review: a separate read-only Cursor subagent (same model family as the implementer, not a human review) reviewed this revision: src/ byte-identical to the previously reviewed 8aefe40; the skill_root=None doc claim matches _protected; the concurrency test is sound (one connection and one BEGIN IMMEDIATE per update, bounded 2 s wait under the 5 s lock timeout). Verdict: ready.
• Dependencies: builds on feat: add normalized knowledge reads and bounded Collect #24 (merged as 4843df2).

Remaining work and Issue closure

• Remaining Issue requirements: none known in code after this PR; complete-Issue acceptance by the owner.
• Goal-acceptance owner: @Dong1017.
• Goal ready for acceptance? Proposed with evidence after merge (criterion map to be posted on [RFC] Knowledge Base v1: Skills, Knowledge, and Internal Experience #17).

Proposed squash message:

feat: publish store-owned candidate bundles in an authorized local store

Create/Update write complete bundles to one explicitly selected SQLite
store outside the installed package and any checkout. Package and checkout
IDs are reserved, adaptations need a distinct ID with derived_from
lineage, entrypoints must be UTF-8, and duplicate/stale/revert writes are
explicit conflicts. History keeps the original resources. Store items join
Collect under qualified store refs.

Agent-assisted-by: Claude Code (Opus) (implementer)
Agent-assisted-by: Cursor Agent (Claude Opus) (implementer)
Signed-off-by: GUOGUO <xwdong1998@163.com>