tools/ci.sh: Fix commit check base branch for 3.x#440
Merged
Conversation
The ci_commit_formatting_run function compared against upstream/master, which caused verifygitlog.py to check all 700+ historical commits on master-2.x-3.x. Many of those were merged with noreply GitHub emails, making the check always fail for any feature branch based on master-2.x-3.x. Fix the base reference to upstream/master-2.x-3.x so only the commits added by a feature branch are verified. Also add --ignore-rebase to match the behaviour of the master branch ci.sh. Signed-off-by: Julian Eder <julian.eder@infineon.com>
The HIL self-hosted runner infrastructure is not configured for the master-2.x-3.x branch, causing the workflow to always fail on every push. Remove it until the HIL setup supports this branch. Signed-off-by: Julian Eder <julian.eder@infineon.com>
The arduino.cc/en/Guide/Introduction URL returns 404. Replace it with the current docs.arduino.cc getting-started page. Also remove the HIL workflow badge since hil-unity-checks.yml is no longer present on this branch. Signed-off-by: Julian Eder <julian.eder@infineon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two CI checks were always failing for feature branches based on
master-2.x-3.x:1. Commit message check (
commit_formatting.yml)ci_commit_formatting_runintools/ci.shcompared againstupstream/master. Sincemaster-2.x-3.xdiverged far frommaster, this causedverifygitlog.pyto check all 700+ historical commits — many of which were merged via GitHub withnoreplyemail addresses — making the check always fail regardless of the new commit's quality.2. HIL unit tests (
hil-unity-checks.yml)The HIL workflow requires a self-hosted runner with physical XMC hardware boards connected. This infrastructure is not configured for the
master-2.x-3.xbranch, so the workflow fails on every push.Fix
tools/ci.sh: Changed base reference fromupstream/mastertoupstream/master-2.x-3.x, and added--ignore-rebaseto match themasterbranch behaviour. Only commits added by a feature branch are now checked..github/workflows/hil-unity-checks.yml: Removed from this branch until the HIL self-hosted runner infrastructure is set up to supportmaster-2.x-3.x.Related
Discovered while working on #439 — missing
__FlashStringHelperString implementations inWString.cpp.