Skip to content

Add RDP E2E tests #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bernie-g wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Add RDP E2E tests #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
33db99f
add RDP E2E tests for PAM module
bernie-g May 11, 2026
fbc6fdf
fix(e2e): seed recording config before creating Windows PAM resources
bernie-g May 11, 2026
a46575e
Merge remote-tracking branch 'origin/main' into feat/pam-rdp-tests
bernie-g May 11, 2026
b720c1a
Merge remote-tracking branch 'origin/main' into feat/pam-rdp-tests
bernie-g May 26, 2026
0004121
fix(e2e): use /auth-only for RDP tests, fix unreachable-target
bernie-g May 26, 2026
d3049da
fix(e2e): regenerate API client with Windows PAM methods, fix xfreerd…
bernie-g May 26, 2026
01d955c
remove accidentally committed api.json
bernie-g May 26, 2026
14a07e8
fix(e2e): retry xfreerdp on transport failure from bridge startup race
bernie-g May 26, 2026
95a21fe
fix(e2e): use freerdp3 instead of freerdp2 for RDP tests
bernie-g May 26, 2026
90b6da2
fix(e2e): start Xvfb in CI, use container.Host for RDP resource
bernie-g May 26, 2026
7098bd3
fix(e2e): warm bridge proxy before xfreerdp to avoid EAGAIN race
bernie-g May 26, 2026
e635118
test(e2e): add direct xrdp connection test to isolate proxy chain issues
bernie-g May 26, 2026
ab046e2
fix(e2e): replace /auth-only with full session, remove warmBridgeProxy
bernie-g May 26, 2026
c530e1f
fix(e2e): retry xfreerdp on transport failure from bridge startup lat…
bernie-g May 26, 2026
6dc4b9f
test(e2e): add TCP-level debug probe to RDP proxy test
bernie-g May 26, 2026
437e502
test(e2e): dump proxy stderr on TCP debug failure
bernie-g May 26, 2026
fbed5df
test(e2e): also dump gateway stderr on TCP debug failure
bernie-g May 26, 2026
824246e
fix(e2e): remove bogus recording config that breaks credential fetch
bernie-g May 26, 2026
9b92ccc
fix(e2e): use postgres storage backend with valid app connection for …
bernie-g May 26, 2026
7516fa3
fix(e2e): use LocalStack for S3/STS mock in RDP recording config
bernie-g May 26, 2026
65e62fa
fix(e2e): use DNS-compatible bucket name for LocalStack S3
bernie-g May 26, 2026
3616509
fix(e2e): bypass S3 validation by inserting recording config via DB
bernie-g May 26, 2026
7f8920e
cleanup: remove debug subtest and extra blank lines in rdp_test
bernie-g May 26, 2026
67be9d2
fix: restore pre-existing comments in pam_helpers.go
bernie-g May 26, 2026
4527958
fix: revert unnecessary go.mod/go.sum version bumps
bernie-g May 26, 2026
80a325f
fix(e2e): use Docker network alias for S3 virtual-hosted-style resolu…
bernie-g May 26, 2026
3c49714
fix(e2e): revert to direct DB insert for recording config
bernie-g May 27, 2026
87894d0
refactor(e2e): use generated client for AWS app connection, remove ap…
bernie-g May 27, 2026
0cecc97
docs: explain why recording config bypasses the API
bernie-g May 27, 2026
201fc00
fix(e2e): avoid t.Skip from goroutine in concurrent RDP test
bernie-g May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/run-cli-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,28 @@ jobs:
go-version: "1.25.9"
- name: Install dependencies
run: go get .
- name: Cache cargo registry + target
uses: actions/cache@v4
with:
path: |
~/.cargo/registry
~/.cargo/git
packages/pam/handlers/rdp/native/target
key: rdp-bridge-cargo-${{ runner.os }}-${{ hashFiles('packages/pam/handlers/rdp/native/Cargo.lock') }}
restore-keys: rdp-bridge-cargo-${{ runner.os }}-
- name: Install pinned Rust toolchain
working-directory: packages/pam/handlers/rdp/native
run: rustup show active-toolchain
- name: Build Rust RDP bridge
working-directory: packages/pam/handlers/rdp/native
run: cargo build --release
- name: Build the CLI
run: go build -o infisical-cli
run: CGO_ENABLED=1 go build -tags rdp -o infisical-cli
- name: Install RDP test dependencies
run: |
sudo apt-get update && sudo apt-get install -y --no-install-recommends freerdp3-x11 xvfb
Xvfb :99 -screen 0 1024x768x24 &
echo "DISPLAY=:99" >> "$GITHUB_ENV"
Comment thread
bernie-g marked this conversation as resolved.
- name: Checkout infisical repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
Expand Down
33 changes: 17 additions & 16 deletions e2e/agent/agent_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,23 @@ func (h *CertAgentTestHelper) CreateInternalCA() {
ProjectId: uuid.MustParse(h.ProjectID),
Status: client.Active,
Configuration: struct {
ActiveCaCertId *openapi_types.UUID `json:"activeCaCertId"`
CommonName *string `json:"commonName,omitempty"`
Country *string `json:"country,omitempty"`
Dn *string `json:"dn"`
FriendlyName *string `json:"friendlyName,omitempty"`
KeyAlgorithm client.CreateInternalCertificateAuthorityV1JSONBodyConfigurationKeyAlgorithm `json:"keyAlgorithm"`
Locality *string `json:"locality,omitempty"`
MaxPathLength *float32 `json:"maxPathLength"`
NotAfter *string `json:"notAfter,omitempty"`
NotBefore *string `json:"notBefore,omitempty"`
Organization *string `json:"organization,omitempty"`
Ou *string `json:"ou,omitempty"`
ParentCaId *openapi_types.UUID `json:"parentCaId"`
Province *string `json:"province,omitempty"`
SerialNumber *string `json:"serialNumber"`
Type client.CreateInternalCertificateAuthorityV1JSONBodyConfigurationType `json:"type"`
ActiveCaCertId *openapi_types.UUID `json:"activeCaCertId"`
CommonName *string `json:"commonName,omitempty"`
Country *string `json:"country,omitempty"`
CrlDistributionPointUrls *[]string `json:"crlDistributionPointUrls,omitempty"`
Dn *string `json:"dn"`
FriendlyName *string `json:"friendlyName,omitempty"`
KeyAlgorithm client.CreateInternalCertificateAuthorityV1JSONBodyConfigurationKeyAlgorithm `json:"keyAlgorithm"`
Locality *string `json:"locality,omitempty"`
MaxPathLength *float32 `json:"maxPathLength"`
NotAfter *string `json:"notAfter,omitempty"`
NotBefore *string `json:"notBefore,omitempty"`
Organization *string `json:"organization,omitempty"`
Ou *string `json:"ou,omitempty"`
ParentCaId *openapi_types.UUID `json:"parentCaId"`
Province *string `json:"province,omitempty"`
SerialNumber *string `json:"serialNumber"`
Type client.CreateInternalCertificateAuthorityV1JSONBodyConfigurationType `json:"type"`
}{
Type: client.Root,
FriendlyName: &friendlyName,
Expand Down
3 changes: 3 additions & 0 deletions e2e/openapi-cfg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ output-options:
- createSshPamResource
- createSshPamAccount
- createRedisPamAccount
- createWindowsPamResource
- createWindowsPamAccount
- createAwsAppConnection
Loading
Loading