Open
Conversation
PR Reviewer Guide 🔍(Review updated until commit b6a5b65)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
sirambd
requested changes
Apr 2, 2026
Comment on lines
48
to
50
Member
There was a problem hiding this comment.
to be applied only to modules that really need it, i.e., where the baseline lint is already defined.
I would even go so far as to say that here, we can ignore the definition of lint if the baseline is null
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
de23833 to
6a747d8
Compare
|
Persistent review updated to latest commit 6a747d8 |
PR Code Suggestions ✨No code suggestions found for the PR. |
LunarX
force-pushed
the
remove-baseline-from-compose-lint-plugin
branch
from
6a747d8 to
6b3bc6d
Compare
PR Code Suggestions ✨No code suggestions found for the PR. |
…pose" This reverts commit 6b3bc6d.
|
Persistent review updated to latest commit b6a5b65 |
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most modules don't need a baseline because it would simply be empty. Also creating a new module would require to generate an empty baseline for no reason. Now baselines are only defined inside of the few modules that actually need one