fix(contracts): equality-only ObjectId filter inputs#81
Open
ahmetcantiryaki wants to merge 2 commits into
Open
fix(contracts): equality-only ObjectId filter inputs#81ahmetcantiryaki wants to merge 2 commits into
ahmetcantiryaki wants to merge 2 commits into
Conversation
WebhookEvent değerlerini SCREAMING_SNAKE'ten backend'in kanonik lowercase-dotted tanımlayıcılarına döndürür (örn. 'policy.created', 'customer.kvkk_consent_given') — backend REST sözleşmesi, delivery payload'ı ($event) ve docs.insurup.com ile birebir aynı. 0.1.40'taki SCREAMING_SNAKE değerleri (sibling enum desenine bakılarak yapılan) yanlış varsayımdı; webhook event'leri kanonik olarak lowercase- dotted. Backend createWebhook bu değerleri kabul etmiyordu (400). Enum üye adları değişmedi; yalnızca wire değerleri. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…odegen - New ObjectIdOperationFilterInput (eq/neq/in/nin); id (and webhookId) filter fields switched from StringOperationFilterInput across proposals, cases, policies, policyTransfers, filePolicyTransfers and webhookDeliveries - mirrors the core schema change that stops exposing substring operators on ObjectId-backed ids (they made mongot 500) - generate-meta: map ObjectIdOperationFilterInput to a new objectId kind; normalize backslashes so the ts-morph glob and primaryDir comparison work on Windows (codegen previously found 0 interfaces and emitted an empty registry) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Özet
core#1178'in contract yansıması: ObjectId-backed
idalanları GraphQL şemasında artık yalnızca eşitlik operatörleri sunuyor (substring operatörleri ObjectId_id'de mongot 500'üne yol açıyordu — trace0f4f89b172bb58dd002bde2fbc6f890d).Değişiklikler
common.ts: yeniObjectIdOperationFilterInput(eq/neq/in/nin).idfilter alanlarıStringOperationFilterInput→ObjectIdOperationFilterInput:proposals,cases,policies,policyTransfers,filePolicyTransfers,webhookDeliveries(id+webhookId) — core'daki[StoredAsObjectId]alan kümesiyle birebir. CustomeridGuid (Uuid input) olduğundan kapsam dışı.generate-meta.ts:ObjectIdOperationFilterInput→ yeniobjectIdkind eşlemesi;idalanlarının meta'sı artıkfilterOperators: ['eq','neq','in','nin']üretiyor.Test Plan
packages/contracts: typecheck / build / test — temiz (88/88), rebase sonrası yeniden koşuldu.generate-meta) — "Generated meta for 9 interfaces".Not
core#1178 ile birlikte değerlendirilmeli; panel tarafı (agent-panel#81) id filtresini zaten client-side
eq/neq+ 24-hex validasyonuna kilitledi, bu contract değişikliği o davranışı tip seviyesinde de garanti altına alıyor.🤖 Generated with Claude Code