Add cross-dataset referential integrity checks#294
Merged
Conversation
validate_rows is intra-row and single-table — its unique rule only dedupes within one batch. Add dbt-style generic checks: check_foreign_key (parent/child across two tables), check_unique_key (single/composite), check_accepted_values, and check_row_count, operating on rows already loaded by load_rows/query_sqlite. Wired through facade, executor (four AC_check_* commands), MCP, and the Script Builder with a headless test batch and EN/Zh docs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 47 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds dbt-style referential checks
validate_rowscouldn't do (it is intra-row, single-table; itsuniqueonly dedupes within one batch).check_foreign_key(child_rows, child_col, parent_rows, parent_col)→{ok, violations, missing}.check_unique_key(rows, cols)— single or composite key →{ok, duplicates}.check_accepted_values(rows, col, allowed)→{ok, violations, unexpected}.check_row_count(rows, minimum=, maximum=)→{ok, count}.Operates on rows from
load_rows/query_sqlite.Layers
utils/referential/(pure stdlibcollections, zero PySide6).__all__.AC_check_foreign_key,AC_check_unique_key,AC_check_accepted_values,AC_check_row_count.ac_check_*(read-only).test/unit_test/headless/test_referential_batch.py(8 tests, no Qt).v86_features_doc.rst(EN + Zh) + toctrees + 3 README What's-new sections.Verification
pytest test/unit_test/headless/test_referential_batch.py→ 8 passed.ruff check je_auto_control/clean; pylint 10.00/10; bandit clean; radon CC clean.