Add secret redaction for config structures and logs#296
Merged
Conversation
utils/redaction only blurs screenshots and secrets_scan only detects — neither returned a masked copy safe for logs, reports, or config export. Add redact_config (deep copy with secret-looking values masked, reusing the secrets_scan detector) and redact_secret_text (mask secret tokens in a log line). Named redact_secret_text to stay distinct from the prompt-injection guardrail.redact_text. Wired through facade, executor (AC_redact_config / AC_redact_secret_text), MCP, and the Script Builder with a headless test batch and EN/Zh docs.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 34 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Produces a masked copy of config or log text —
utils/redactiononly blurs screenshots andsecrets_scanonly detects findings.redact_config(obj, *, mask="***")— deep copy with secret-looking values masked, reusing thesecrets_scandetector (key-name patterns, AWS/bearer formats, high-entropy strings); vault refs (${secrets.*}) left intact.redact_secret_text(text, *, mask="***")— masks secret-looking tokens in a free-text log line, preserving surrounding words/whitespace.Named
redact_secret_textto stay distinct from the prompt-injectionguardrail.redact_text(facade symbol clash avoided).Layers
utils/config_redaction/(pure stdlibre+secrets_scan, zero PySide6).redact_config,redact_secret_text+__all__.AC_redact_config,AC_redact_secret_text.ac_redact_config,ac_redact_secret_text(read-only).test/unit_test/headless/test_config_redaction_batch.py(9 tests; secret-shaped values built at runtime).v88_features_doc.rst(EN + Zh) + toctrees + 3 README What's-new sections.Verification
pytest test/unit_test/headless/test_config_redaction_batch.py→ 9 passed.ruff check je_auto_control/clean; pylint 10.00/10; bandit clean; radon CC clean.