Skip to content

Add blocking wait-until-vanish (wait_until_gone / image / text)#328

Merged
JE-Chen merged 1 commit into
devfrom
feat/wait-gone-batch
Jun 22, 2026
Merged

Add blocking wait-until-vanish (wait_until_gone / image / text)#328
JE-Chen merged 1 commit into
devfrom
feat/wait-gone-batch

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Round-11, automation-core. wait_for_image/wait_for_text block until something appears and observer fires async callbacks on vanish, but there was no blocking "wait until this spinner/toast/dialog disappears then continue" for an image or text (wait_until_window_closed covers windows only). Adds the missing vanish waits to the smart_waits family.

Layers

  • Headless core: extends je_auto_control/utils/smart_waits/waits.py — generic wait_until_gone(present, ...) (any predicate → loop is headless-testable), plus wait_until_image_gone / wait_until_text_gone building the predicate from the locate functions. Returns the existing WaitOutcome. gone_for_s debounces flicker.
  • Facade: all three re-exported + __all__.
  • Executor: AC_wait_image_gone, AC_wait_text_gone.
  • MCP: ac_wait_image_gone / ac_wait_text_gone.
  • Script Builder: two CommandSpecs under Flow.

Tests / docs

  • test/unit_test/headless/test_wait_gone_batch.py — 7 headless tests (predicate flips to false, already-gone immediate, timeout, validation, gone_for_s sustained-absence + wiring + facade) — all via injected predicates, no real screen.
  • EN/Zh feature docs v118_features_doc.rst + toctrees; 3 WHATS_NEW changelog entries.

Note: Codacy may show action_required from its coverage gate only (issues=0); SonarCloud + all GitHub Actions are the substantive gates.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen JE-Chen merged commit 40a4733 into dev Jun 22, 2026
15 of 16 checks passed
@JE-Chen JE-Chen deleted the feat/wait-gone-batch branch June 22, 2026 16:25
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant