Skip to content

Add held-modifiers context across an action group#333

Merged
JE-Chen merged 1 commit into
devfrom
feat/modifier-state-batch
Jun 22, 2026
Merged

Add held-modifiers context across an action group#333
JE-Chen merged 1 commit into
devfrom
feat/modifier-state-batch

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Round-11, automation-core. hotkey releases its keys immediately — no way to hold ctrl/shift down across several independent actions (shift-click range select, ctrl-click multi-select) with a guaranteed release.

Layers

  • Headless core: je_auto_control/utils/modifier_state/modifier_state.pyhold_modifiers (context manager: press on enter, release reversed on exit in a finally), plan_with_modifiers (pure op-plan). Injectable sink; no PySide6.
  • Facade: both re-exported + __all__.
  • Executor: AC_with_modifiers (runs a nested JSON action list while modifiers held, release-safe — mirrors the bulkhead nested-action pattern).
  • MCP: ac_with_modifiers (SIDE_EFFECT_ONLY).
  • Script Builder: one CommandSpec under Keyboard.

Tests / docs

  • test/unit_test/headless/test_modifier_state_batch.py — 7 headless tests (plan reversed-release, context press/body/release, release-even-on-exception, yields modifier list + wiring + facade). No real input.
  • EN/Zh feature docs v123_features_doc.rst + toctrees; 3 WHATS_NEW entries.

Note: Codacy may show action_required from its coverage gate only (issues=0); SonarCloud + all GitHub Actions are the substantive gates.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen JE-Chen merged commit 3be72ea into dev Jun 22, 2026
15 of 16 checks passed
@JE-Chen JE-Chen deleted the feat/modifier-state-batch branch June 22, 2026 17:59
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant