Add held-modifiers context across an action group#333
Merged
Conversation
Not up to standards ⛔
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Round-11, automation-core.
hotkeyreleases its keys immediately — no way to holdctrl/shiftdown across several independent actions (shift-click range select, ctrl-click multi-select) with a guaranteed release.Layers
je_auto_control/utils/modifier_state/modifier_state.py—hold_modifiers(context manager: press on enter, release reversed on exit in afinally),plan_with_modifiers(pure op-plan). Injectable sink; no PySide6.__all__.AC_with_modifiers(runs a nested JSON action list while modifiers held, release-safe — mirrors the bulkhead nested-action pattern).ac_with_modifiers(SIDE_EFFECT_ONLY).CommandSpecunder Keyboard.Tests / docs
test/unit_test/headless/test_modifier_state_batch.py— 7 headless tests (plan reversed-release, context press/body/release, release-even-on-exception, yields modifier list + wiring + facade). No real input.v123_features_doc.rst+ toctrees; 3 WHATS_NEW entries.Note: Codacy may show
action_requiredfrom its coverage gate only (issues=0); SonarCloud + all GitHub Actions are the substantive gates.