Skip to content

Add wait-for-window-title regex (appear/vanish)#336

Merged
JE-Chen merged 1 commit into
devfrom
feat/wait-window-title-batch
Jun 22, 2026
Merged

Add wait-for-window-title regex (appear/vanish)#336
JE-Chen merged 1 commit into
devfrom
feat/wait-window-title-batch

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Round-11, automation-core (sync lane). wait_for_window matches a title substring and only waits for appear; wait_until_window_closed is substring vanish. Neither supports a regex title or waiting for a title to match/vanish — e.g. a tab navigating to r".*— Checkout$".

Layers

  • Headless core: extends smart_waits/waits.pywait_until_window_title (regex by default via re.search, regex=False for substring; present=False for vanish) + pure _title_matches helper. Injectable title_lister. Returns the existing WaitOutcome.
  • Facade: wait_until_window_title + WindowTitleLister re-exported + __all__.
  • Executor: AC_wait_window_title.
  • MCP: ac_wait_window_title.
  • Script Builder: one CommandSpec under Flow.

Tests / docs

  • test/unit_test/headless/test_wait_window_title_batch.py — 7 headless tests (regex appears, substring mode, vanish, timeout, validation + wiring + facade) via injected title lister.
  • EN/Zh feature docs v126_features_doc.rst + toctrees; 3 WHATS_NEW entries.

Note: Codacy may show action_required from its coverage gate only (issues=0); SonarCloud + all GitHub Actions are the substantive gates.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen JE-Chen merged commit 7901e62 into dev Jun 22, 2026
15 of 16 checks passed
@JE-Chen JE-Chen deleted the feat/wait-window-title-batch branch June 22, 2026 18:43
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant