Add critic_features: per-step critic bundle + rule-based scorer#391
Merged
Conversation
trajectory_eval scores a whole trajectory with no per-step evidence;
agent_trace emits spans not quality; agent_replay stores steps but doesn't
score. Compose action_effect + observation_delta + postcondition into one
per-step record, then a deterministic rule-based scorer gives
{outcome, process_score, reasons} (no model), and to_judge_prompt renders it for
an optional LLM-as-judge.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 22 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
新增
build_critic_record/score_step_rule_based/to_judge_prompt— 把為代理步驟評分所需的證據打包成單一逐步記錄,並附規則式評分器。trajectory_eval對整條軌跡評分而無逐步證據;agent_trace發出 span(權杖/延遲)而非決策品質;agent_replay保存{obs, action, result}卻不評分。本功能把
action_effect(有無效果、落點)+observation_delta(變了多少)+postcondition(預期是否成立)組合成精簡記錄,並附確定性規則式評分器使其可完整無頭運作——可選的 LLM-as-judge 留給整合者(to_judge_prompt)。純標準函式庫聚合器;組合既有純模組。Qt-free。五層
utils/critic_features/—build_critic_record、score_step_rule_based、to_judge_prompt。AC_build_critic_record+AC_score_step/ MCPac_build_critic_record+ac_score_step/ Script Builder(Native UI)。測試
test_critic_features_batch.py— 記錄捕捉 effect+delta、好步驟評分、no_op 失敗、postcondition 失敗降 outcome、to_judge_prompt 含 effect、wiring + facade。7 passed。ruff / bandit / radon / float-scan / Qt-free 全乾淨。