workaround for circular dependency#192
Merged
Merged
Conversation
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to implement a workaround for a circular dependency issue by modifying the order of imports in the numpy FFT interface. The changes remove the early import of certain numpy FFT functions and reintroduce them later in the file with additional comments to clarify the reasoning.
ekomarova
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of import in
mkl_fft/interfaces/numpy_fft.pyis modified to avoid circular dependency when patching numpy FFT module withmkl_ftt.