feat(layout): standardized two-line PageBar (title + subtitle)#1149
Open
psdjungpulzze wants to merge 1 commit into
Open
feat(layout): standardized two-line PageBar (title + subtitle)#1149psdjungpulzze wants to merge 1 commit into
psdjungpulzze wants to merge 1 commit into
Conversation
Redesign the global PageBar from a single-line title strip into the
standardized two-line header: bold title (#1C1C1E) + one-sentence
secondary subtitle (#8E8E93), sourced from resolvePageMeta with context
override still honored.
- Extend page-bar-context with a subtitle override (usePageSubtitle),
mirroring the undefined=resolve / null=suppress / string=explicit
semantics already used for the title. A null title still suppresses
the whole bar; a null/empty subtitle just drops the second line.
- Grow the bar to fit two lines; the subtitle line is omitted when empty.
- Seed page-meta registry entries for change-requests, flags, epics
(and add an "epics" SEGMENT_LABELS fallback now that the explicit
usePageTitle("Epics") is gone).
- Migrate those 3 pages off the in-body ui/PageHeader: remove their
duplicate title/subtitle so the global bar is the single source, and
keep the primary action on the filter-tabs toolbar. Flags keeps its
live count via usePageSubtitle.
Builds on the page-meta registry (#1147).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the global PageBar (
src/components/layout/page-bar.tsx, rendered inresizable-layout.tsx) from a single-line title strip into the standardized two-line header: bold title (#1C1C1E) + one-sentence secondary subtitle (#8E8E93), sourced fromresolvePageMetawith context overrides still honored.Built on top of the page-meta registry (#1147) — base branch is
feat/page-meta-registryso this PR shows only the header delta. It will auto-retarget tomainonce #1147 merges.Changes
page-bar.tsx— two-line layout; title fromresolvePageMeta(pathname).title, subtitle from.subtitle. Subtitle line is omitted when empty; a null/empty title still suppresses the whole bar. Bar grows to fit two lines (flex-col,py-2) while keeping the existing border/surface tokens.page-bar-context.tsx— adds asubtitleslot +usePageSubtitle()hook, mirroring the existingundefined = resolve / null = suppress / string = explicittitle semantics.usePageTitle(null)keeps its null = suppress-whole-bar behavior.page-meta.ts— seeds registry entries forchange-requests,flags,epics; adds anepicsSEGMENT_LABELSfallback (the explicitusePageTitle("Epics")is removed).change-requests,flags,epicsdrop the in-bodyui/PageHeaderso the global bar is the single source of title/subtitle. Each keeps its primary action on a toolbar alongside the filter tabs. Flags surfaces its live count viausePageSubtitle.Verification
npm run typecheck✅npm run build✅ compiles + passes the TypeScript stage (page-data collection fails only on missingDATABASE_URL, an environment limitation, not a code issue)vitest run src/components/layout/page-meta.test.ts✅ 19/19eslinton changed files ✅ (only pre-existing underscore-param warnings)Agent config
No PM Agent update needed — this is a presentational layout change (header rendering); it adds no tools, entities, statuses, or workflows the agent surfaces.
🤖 Generated with Claude Code