Repository navigation
Switch PSU Status: "Present" PSUs have no power; fix VC and CX grading - #9
Merged
Merged
Conversation
Checked against a live org: - Junos "Present" means a PSU is installed but not supplying power. It was counted as OK, so a VC member with one unpowered PSU read as Redundant. It is now its own "No power" class and grades the switch "PSU failed / no power". - 1.1.2's missing-member check counted Mist's virtual chassis inventory row (its serial is the VC MAC) as a member, and compared non-VC chassis serials with module serials, so it flagged almost every VC. It now uses only real VC members, and skips switches that send no module data at all. - CX switches list PSUs, management modules, line cards and fan trays as separate modules. PSUs with no FPC or VC role are now pooled into one chassis, and modules without PSUs are skipped. - PSUs are listed in name order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PSU grading, checked against a live org (23 switches, EX and CX):
Present= installed, no power. It was counted as OK. A VC whose members each reportpresent+okread as Redundant, and so did a switch withok, present, present. There is now a No power PSU class, and the switch is graded PSU failed / no power.Live org before → after: 4 false Member missing, 2 unpowered PSU cases graded Redundant → 2 PSU failed / no power, 0 Member missing, CX6405 Redundant.
Tests: 5 new fixtures shaped like the live data; existing tests updated for the chassis row.
🤖 Generated with Claude Code