Skip to content

BRIX-1411 add Quay review PR ingress#111

Merged
lafawnduh1966 merged 2 commits into
devfrom
fabiansche/BRIX-1411
May 15, 2026
Merged

BRIX-1411 add Quay review PR ingress#111
lafawnduh1966 merged 2 commits into
devfrom
fabiansche/BRIX-1411

Conversation

@lafawnduh1966
Copy link
Copy Markdown
Contributor

Summary:

  • Add dedicated-token POST /quay/review-pr to the API server with payload validation and structured Quay JSON responses.
  • Invoke local quay-as-hermes review-pr with QUAY_DATA_DIR pinned to the Hermes profile data dir.
  • Stage QUAY_REVIEW_PR_TOKEN through deploy secrets and document a GitHub Actions curl example.
  • Cover auth, payload validation, command invocation, and Quay failure handling in API server tests.

Validation:

  • bash -n stage-secrets.sh
  • python -m py_compile gateway/platforms/api_server.py hermes_cli/config.py
  • scripts/run_tests.sh tests/gateway/test_api_server.py::TestQuayReviewPrEndpoint
  • scripts/run_tests.sh tests/gateway/test_api_server.py
  • scripts/run_tests.sh tests/tools/test_local_env_blocklist.py

Linear: https://linear.app/inverter/issue/BRIX-1411/add-authenticated-http-endpoint-to-enroll-prs-for-quay-review

@linear
Copy link
Copy Markdown

linear Bot commented May 15, 2026

BRIX-1411

@lafawnduh1966
Copy link
Copy Markdown
Contributor Author

Addressed the two review notes in 9f28a3e:

  • quay-as-hermes now preserves an explicit QUAY_DATA_DIR in both the same-user gateway path and the sudo/operator path, falling back to the install target only when unset.
  • Added wrapper tests covering both override paths.
  • Added the Quay review endpoint env vars and QUAY_DATA_DIR behavior to the public environment variable reference, and clarified the BRIX endpoint note/runbook wording.

Validation:

  • bash -n ops/quay-as-hermes
  • scripts/run_tests.sh tests/ops/test_quay_as_hermes_wrapper.py
  • scripts/run_tests.sh tests/gateway/test_api_server.py::TestQuayReviewPrEndpoint

@lafawnduh1966 lafawnduh1966 merged commit e0613f0 into dev May 15, 2026
1 check passed
lafawnduh1966 added a commit that referenced this pull request May 15, 2026
* BRIX-1411 add Quay review PR ingress

* Address BRIX-1411 review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant