Sumeru / #984 - Remove insecure AES/CBC/PKCS5Padding for new encryption#1032
Closed
sumeruchat wants to merge 1 commit intomasterfrom
Closed
Sumeru / #984 - Remove insecure AES/CBC/PKCS5Padding for new encryption#1032sumeruchat wants to merge 1 commit intomasterfrom
sumeruchat wants to merge 1 commit intomasterfrom
Conversation
Always use AES/GCM/NoPadding for encryption. Legacy CBC decryption retained for backward compatibility with existing encrypted data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sumeruchat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnsupportedOperationExceptionon pre-KitKat devices instead of falling back to vulnerable CBC modeTest plan
IterableDataEncryptorTest— updated tests validate legacy decrypt + modern-only encrypt🤖 Generated with Claude Code