Sumeru / #997 - Fix IterableEmbeddedView to match campaign preview#1034
Closed
sumeruchat wants to merge 1 commit intomasterfrom
Closed
Sumeru / #997 - Fix IterableEmbeddedView to match campaign preview#1034sumeruchat wants to merge 1 commit intomasterfrom
sumeruchat wants to merge 1 commit intomasterfrom
Conversation
Fix card view image height to use wrap_content with adjustViewBounds for proper image sizing. Change scaleType to fitCenter. Fix notification_view_border.xml swapped stroke/solid colors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sumeruchat
changed the title
franco-zalamena-iterable
deleted the
sumeru/997-fix-embedded-view-campaign-preview-mismatch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0dpconstrained towrap_contentwithadjustViewBoundsfor proper image sizingscaleTypefromcenterCroptofitCenterto match campaign preview rendering120dpheight towrap_contentfor dynamic sizingnotification_view_border.xmlwhere stroke and solid colors were swapped (border showed as background color and vice versa)Test plan
🤖 Generated with Claude Code