fix: handle WebView initialization failure gracefully (#1013)#1037
Closed
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Closed
fix: handle WebView initialization failure gracefully (#1013)#1037franco-zalamena-iterable wants to merge 1 commit intomasterfrom
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Conversation
…MLNotification (#1013) Wrap IterableWebView instantiation in try-catch to gracefully handle AndroidRuntimeException when WebView process is unavailable, preventing app crashes. On failure, logs the error and dismisses the in-app message. - Broadened createWebViewSafely() to catch Exception (in addition to Resources.NotFoundException and RuntimeException) with a descriptive comment about AndroidRuntimeException from WebViewFactory - Added try-catch in IterableWebView.createWithHtml() to guard against exceptions during WebView configuration/setup - Added TAG constant to IterableWebView for consistent logging Made-with: Cursor
| getSettings().setAllowContentAccess(false); | ||
| // disallow unnecessary access | ||
| getSettings().setAllowFileAccess(false); | ||
| getSettings().setAllowFileAccessFromFileURLs(false); |
| // disallow unnecessary access | ||
| getSettings().setAllowFileAccess(false); | ||
| getSettings().setAllowFileAccessFromFileURLs(false); | ||
| getSettings().setAllowUniversalAccessFromFileURLs(false); |
Contributor
Author
PR AnalysisProblem: Ideal fix plan:
What the PR did:
Assessment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps
IterableWebViewinstantiation inIterableInAppFragmentHTMLNotification.onCreateView()with a try-catch to handleAndroidRuntimeExceptionwhen the WebView process is unavailable or fails to initialize. Instead of crashing, the SDK now logs the error and dismisses the in-app message gracefully.Changes
createWebViewSafely()to catchExceptionas a final fallback (in addition toResources.NotFoundExceptionandRuntimeException), with an explicit comment aboutAndroidRuntimeExceptionfromWebViewFactoryIterableWebView.createWithHtml()to guard against exceptions during WebView configuration/setupTAGconstant toIterableWebViewfor consistent log taggingTest plan
Made with Cursor