Skip to content

Add deleteAction field to trackInAppConsume for inAppDelete events#571

Closed
franco-zalamena-iterable wants to merge 1 commit intoIterable:mainfrom
franco-zalamena-iterable:feat/486-add-delete-action-inapp-consume
Closed

Add deleteAction field to trackInAppConsume for inAppDelete events#571
franco-zalamena-iterable wants to merge 1 commit intoIterable:mainfrom
franco-zalamena-iterable:feat/486-add-delete-action-inapp-consume

Conversation

@franco-zalamena-iterable
Copy link
Copy Markdown

@franco-zalamena-iterable franco-zalamena-iterable commented Apr 7, 2026

Summary

  • Add optional deleteAction field to InAppEventRequestParams type
  • Update event schema to include deleteAction validation
  • Enables generation of inAppDelete events via trackInAppConsume

Test plan

  • Verify trackInAppConsume accepts deleteAction parameter
  • Verify deleteAction is sent in the API request body
  • TypeScript compilation passes

🤖 Generated with Claude Code

The trackInAppConsume endpoint supports a deleteAction field that
generates an inAppDelete event, but the SDK did not expose this field.
Add it to InAppEventRequestParams and the event request schema.

Fixes Iterable#486

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (190a168) to head (adc7094).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files          57       57           
  Lines        2736     2736           
  Branches      798      798           
=======================================
  Hits         2037     2037           
  Misses        698      698           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@franco-zalamena-iterable franco-zalamena-iterable deleted the feat/486-add-delete-action-inapp-consume branch April 8, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants