Skip to content

Fixes Xcode build issues #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexstaravoitau wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes Xcode build issues #789

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7231c2
Switch to angled header import
alexstaravoitau Dec 2, 2025
0fddee5
Merge branch 'master' into fix-xcode-build-issues
lposen Jan 9, 2026
811b69c
Use conditional Swift header import
alexstaravoitau Jan 28, 2026
811db52
Merge branch 'fix-xcode-build-issues' of github.com:alexstaravoitau/r…
alexstaravoitau Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/RNIterableAPI/RNIterableAPI.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ typedef NS_ENUM(NSInteger, InAppShowResponse) {
skip = 1,
};

#import "Iterable_React_Native_SDK-Swift.h"
#import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>
Copy link
Copy Markdown
Contributor

@lposen lposen Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexstaravoitau. This could potentially break things depending on a users podfile setup. It would be safer for this to be conditional to account for that.

Untested pseudocode example:

#if __has_include(<Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>)
  #import <Iterable_React_Native_SDK/Iterable_React_Native_SDK-Swift.h>
#else
  #import "Iterable_React_Native_SDK-Swift.h"
#endif

Copy link
Copy Markdown
Author

@alexstaravoitau alexstaravoitau Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, updated. 👌


@interface RNIterableAPI () <ReactIterableAPIDelegate>
@end
Expand Down
Loading