Surface push registration errors instead of failing silently#844
Closed
franco-zalamena-iterable wants to merge 1 commit intoIterable:masterfrom
Closed
Conversation
When pushIntegrationName is invalid, the registerDeviceToken API call previously failed silently. This change implements the onTokenRegistrationFailed callback in both iOS and Android native modules to log errors and emit events that JS code can listen to. Fixes Iterable#469 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
franco-zalamena-iterable
deleted the
fix/469-surface-push-registration-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleTokenRegistrationFailedCalledevent from native to JS when registration failsonTokenRegistrationFailedcallback toIterableConfigso JS code can listen for registration failuresTest plan
onTokenRegistrationFailedcallback fires with reason🤖 Generated with Claude Code