Skip to content

Fix createdAt/expiresAt to return proper Date objects #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
franco-zalamena-iterable wants to merge 1 commit into from
+7 −13
Closed

Fix createdAt/expiresAt to return proper Date objects #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions src/inApp/classes/IterableInAppMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,13 @@ export class IterableInAppMessage {
const campaignId = dict.campaignId;
const trigger = IterableInAppTrigger.fromDict(dict.trigger);

let createdAt = dict.createdAt;
if (createdAt) {
const dateObject = new Date(0);
createdAt = dateObject.setUTCMilliseconds(createdAt);
let createdAt: Date | undefined;
if (dict.createdAt) {
createdAt = new Date(dict.createdAt);
}
let expiresAt = dict.expiresAt;
if (expiresAt) {
const dateObject = new Date(0);
expiresAt = dateObject.setUTCMilliseconds(expiresAt);
let expiresAt: Date | undefined;
if (dict.expiresAt) {
expiresAt = new Date(dict.expiresAt);
}
const saveToInbox = IterableUtil.readBoolean(dict, 'saveToInbox');
const inboxMetadataDict = dict.inboxMetadata;
Expand All @@ -196,16 +194,12 @@ export class IterableInAppMessage {
const customPayload = dict.customPayload;
const read = IterableUtil.readBoolean(dict, 'read');

const priorityLevel = dict.priorityLevel;
const priorityLevel = dict.priorityLevel ?? 0;

return new IterableInAppMessage(
messageId,
campaignId,
trigger,
// MOB-10426: Speak to the team about `IterableInAppMessage` requiring a date
// object, but being passed a number in this case
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
createdAt,
expiresAt,
saveToInbox,
Expand Down
Loading