Sumeru / #770 - Fix implicit dependency on @react-navigation/native#850
Open
sumeruchat wants to merge 1 commit intomasterfrom
Open
Sumeru / #770 - Fix implicit dependency on @react-navigation/native#850sumeruchat wants to merge 1 commit intomasterfrom
sumeruchat wants to merge 1 commit intomasterfrom
Conversation
The SDK imported `useIsFocused` directly from `@react-navigation/native` in the IterableInbox component, causing build failures for apps that do not use React Navigation. This change introduces a wrapper hook that tries to load `useIsFocused` from `@react-navigation/native` at module load time and falls back to always returning `true` when the package is not installed. The peer dependency is also marked as optional in peerDependenciesMeta. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@react-navigation/nativean optional dependency instead of an implicit hard requirementTest plan
@react-navigation/nativeinstalled@react-navigation/nativeinstalled🤖 Generated with Claude Code