Sumeru / #581 - Fix IterableInAppMessage.createdAt type mismatch causing crashes#851
Open
sumeruchat wants to merge 1 commit intomasterfrom
Open
Sumeru / #581 - Fix IterableInAppMessage.createdAt type mismatch causing crashes#851sumeruchat wants to merge 1 commit intomasterfrom
sumeruchat wants to merge 1 commit intomasterfrom
Conversation
The native bridge sends epoch milliseconds (number) for createdAt and expiresAt, but the previous code used setUTCMilliseconds which returns a number instead of a Date object. This caused runtime crashes when consumers tried to use createdAt as a Date. Replace with new Date() constructor to properly convert timestamps. Also removes the @ts-ignore workaround and provides a default for priorityLevel. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IterableInAppMessage.createdAtandexpiresAtthat causes runtime crashessetUTCMilliseconds()returns a number, not aDate— so consumers calling Date methods oncreatedAtwould crashnew Date(milliseconds)to properly convert timestamps toDateobjects@ts-ignoreworkaround that was masking the type errorpriorityLevelto fix exposed type issueTest plan
createdAtandexpiresAtreturn validDateobjects fromfromDictundefinedtimestamps remainundefinedcreatedAton in-app messages in a running app🤖 Generated with Claude Code