Skip to content

[SDK-484] Remove legacy arch#872

Open
lposen wants to merge 4 commits into
masterfrom
remove-legacy-arch
Open

[SDK-484] Remove legacy arch#872
lposen wants to merge 4 commits into
masterfrom
remove-legacy-arch

Conversation

@lposen

@lposen lposen commented May 27, 2026

Copy link
Copy Markdown
Contributor

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@github-actions

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 68%
68.83% (519/754) 56.11% (202/360) 64.82% (164/253)

@qltysh

qltysh Bot commented May 27, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on 0-85-new by 5.87%.

Modified Files with Diff Coverage (13)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/api/index.ts100.0%
New Coverage rating: A
...edded/components/IterableEmbeddedCard/IterableEmbeddedCard.tsx100.0%
New Coverage rating: A
...bleEmbeddedNotification/IterableEmbeddedNotification.styles.ts100.0%
New Coverage rating: A
src/embedded/hooks/useEmbeddedView/getMedia.ts100.0%
New Coverage rating: A
...components/IterableEmbeddedCard/IterableEmbeddedCard.styles.ts100.0%
New Coverage rating: A
src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts100.0%
New Coverage rating: A
...d/components/IterableEmbeddedBanner/IterableEmbeddedBanner.tsx100.0%
New Coverage rating: A
src/embedded/components/IterableEmbeddedView.tsx100.0%
New Coverage rating: A
src/embedded/utils/normalizeEmbeddedViewConfig.ts94.3%13, 17
New Coverage rating: A
src/embedded/constants/embeddedViewDefaults.ts100.0%
New Coverage rating: A
src/embedded/hooks/useEmbeddedView/getStyles.ts100.0%
New Coverage rating: A
.../IterableEmbeddedNotification/IterableEmbeddedNotification.tsx100.0%
New Coverage rating: A
...onents/IterableEmbeddedBanner/IterableEmbeddedBanner.styles.ts100.0%
Total98.4%
🤖 Increase coverage with AI coding...
In the `remove-legacy-arch` branch, add test coverage for this new code:

- `src/embedded/utils/normalizeEmbeddedViewConfig.ts` -- Lines 13 and 17

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Base automatically changed from 0-85-new to master June 11, 2026 20:20
@qltysh

qltysh Bot commented Jun 11, 2026

Copy link
Copy Markdown

Qlty


⚠️ Comments skipped @lposen doesn't have a Qlty seat in Iterable.

Qlty doesn't post analysis or coverage comments for contributors without a seat. An authorized user can grant @lposen a seat from this pull request's page in Qlty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant