Search for pronouns in field values, names and the bio#72
Draft
nachtjasmin wants to merge 8 commits into
Draft
Conversation
Owner
|
With all the new pronouns from all languages we get false positives, such as "I" for https://botsin.space/@lesbianBot. Also logging could be a bit improved - the addon doesn't output any info after fetching a status |
87aef3e to
abcbadb
Compare
The old approach was refactored. With this commit we are applying all searches to each individual field, including their name and value. This approach is optimized for speed in that regard, that we do the API calls as the last step.
too many false positives for comma
71bb62e to
907405d
Compare
Contributor
Author
|
Although it looks fine to me, I won't merge it unless I've fixed the following problem: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old approach was refactored. With this PR we are applying all searches to each individual field, including their name and value. This approach is optimized for speed in that regard, that we do the API calls as the last step.
I also embedded a list of all known pronoun.page pronouns, which can be generated using
node scripts/generateKnownPronouns.mjs. The current state is commited to the repository and could be regenerated at any time.A lot of the cases mentioned in #63 are going to be closed with this PR.