Refactor the codebase to TypeScript#74
Draft
nachtjasmin wants to merge 7 commits into
Draft
Conversation
nachtjasmin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I got annoyed by the polyfill desaster and the different ways of handling browser-specific code,
I've decided to begin the refactoring to TypeScript.
At least, TypeScript has interfaces and although we could work without it and keep a pure JS codebase,
it's probably the cleanest way of doing such things. Instead of relying on the polyfill,
we now can use dependency injection and therefore don't need to mock module imports.