fix: prevent TypeError in pg-query-stream with client-side query_timeout#280
Merged
Conversation
JS-AK
commented
Oct 14, 2025
JS-AK
commented
Owner
- Temporarily disable client.query_timeout and client.connectionParameters.query_timeout during streaming
- Restore original values on stream end/error/close
- Add double-release guard for pooled clients
- Add tests for both pool and direct client scenarios
- Fixes node-postgres issue #1860: "Query streams break with query_timeout"
- Temporarily disable client.query_timeout and client.connectionParameters.query_timeout during streaming - Restore original values on stream end/error/close - Add double-release guard for pooled clients - Add tests for both pool and direct client scenarios - Fixes node-postgres issue #1860: "Query streams break with query_timeout"
Owner
Author
|
🎉 This PR is included in version 3.48.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.