Skip to content

Fix save actions#9890

Merged
calixtus merged 4 commits into
mainfrom
fix-9881
May 15, 2023
Merged

Fix save actions#9890
calixtus merged 4 commits into
mainfrom
fix-9881

Conversation

@koppor

@koppor koppor commented May 15, 2023

Copy link
Copy Markdown
Member

This fixes #9881.

While playing around, I found out that we had two major issues:

  1. The order of the save actions was not retained. They were sorted alphabetically by field. I think, as user, I want to have some logical order of the fields (and not JabRef reordering my things)
  2. The remove_unicode_formatter was not parsed. Never. Therefore, I took the liberty and adapted the name to the name of the class - and enabled its parsing.

As a result, no save actions are written if they are the default.

More info: The list of save actions was compared as list for checking if they are the default. Since that list was not ordered by field name (in #9126), it was always different.

### Compulsory checks
- [x] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)
- [ ] Tests created for changes (if applicable)
- [ ] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for UI changes)
- [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

@JabRef JabRef deleted a comment from github-actions Bot May 15, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 15, 2023
@calixtus calixtus merged commit 7aa8052 into main May 15, 2023
@calixtus calixtus deleted the fix-9881 branch May 15, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary "Review Changes" checks

3 participants