feat: add preference to show full file path in data links; add labels for UI display to data links#344
Open
allison-truhlar wants to merge 15 commits intomainfrom
Open
feat: add preference to show full file path in data links; add labels for UI display to data links#344allison-truhlar wants to merge 15 commits intomainfrom
allison-truhlar wants to merge 15 commits intomainfrom
Conversation
Collapse /files/{key}/{sharing_name}/{path} into /files/{key}/{path}. _get_file_proxy_client now resolves subpath by matching captured_path against stored path or basename with boundary guards. This is backwards compatible with existing links because {sharing_name} used to just be the name of the directory the data link was being created for (now called a non-transparent link)
also needed to update the mock for /api/proxied-path for the DataLinkDialog test
New mutation with optimistic rollback for PUT /api/proxied-path/:key.
also change the column heading on the data link table from "name" to "label"
krokicki
reviewed
Apr 9, 2026
Member
krokicki
left a comment
krokicki
left a comment
There was a problem hiding this comment.
I like the data labels!
For the transparent URLs, it shows me that the link will look like this:
https://.../<key>/annotations/jrc_P3-E5-D1-N2_v2_destreaked/crop12/crop12cell_labels_for_ML/amira_export.zarr
It needs to include the full path (i.e. mount path of the FSP at the beginning) to be fully transparent.
| sharing_key: proxiedPathByFspAndPathQuery.data!.sharing_key, | ||
| sharing_name: newLabel | ||
| }); | ||
| toast.success('Data link label updated'); |
Member
There was a problem hiding this comment.
I think this is the same code as handleConfirmLabel in linksColumn. Is there a way to reuse it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup ids: 86abc1mrr; 86a9drafp
This PR adds two features:
sharing_name) — a display-only label for the data link (shown in the "Label" column on the Links page). The variable namesharing_nameis kept throughout the codebase; only the UI label changes to "Label". Editable at any time without breaking the link. Defaults topath_basename, as previously done for thesharing_namevalue. The user can access the edit dialog via the properties panel in the file browser (when navigated to a directory with a data link) or via the action menu for a given link row in the data link table on the /links page.